xsteadfastx/jellyfixer
1
0
Fork 1
Code Issues Pull Requests Releases 5 Wiki Activity

Added Tpye instead map #1

Manually merged
xsteadfastx merged 2 commits from Koma-Andrea/jellyfixer:typeinsteadmap into master 2020-12-09 08:38:29 +01:00
Conversation 3 Commits 2 Files Changed 2 +18 -12
Koma-Andrea commented 2020-12-08 12:53:36 +01:00
Contributor
Copy Link

I've Added a Type instead of the map which will not work with boolean to be unmarshalled.

I'm also using JELLYFIN_URL as environment variable instead of removing the value. I found that this works better in various scenario.

I've Added a Type instead of the map which will not work with boolean to be unmarshalled. I'm also using JELLYFIN_URL as environment variable instead of removing the value. I found that this works better in various scenario.
xsteadfastx reviewed 2020-12-08 13:48:48 +01:00
main.go
@ -68,3 +72,1 @@
return
}
url := os.Getenv("JELLYFIN_URL")
xsteadfastx commented 2020-12-08 13:48:48 +01:00
Owner
Copy Link

is this needed? cant we use the baseurl?

is this needed? cant we use the baseurl?
Koma-Andrea commented 2020-12-08 15:02:10 +01:00
Author
Contributor
Copy Link

The JELLYFIN_URL is the external URL, while the baseurl (that you pick as an argument) is the jellyfin container's name.

The JELLYFIN_URL is the external URL, while the baseurl (that you pick as an argument) is the jellyfin container's name.
Koma-Andrea commented 2020-12-08 15:03:20 +01:00
Author
Contributor
Copy Link

I would also suggest to pick both values as environment values or to use both named arguments and environment values.

I would also suggest to pick both values as environment values or to use both named arguments and environment values.
xsteadfastx commented 2020-12-09 08:08:28 +01:00
Owner
Copy Link

will merge this today. i will add viper and make it use config files and or environment variables.

will merge this today. i will add viper and make it use config files and or environment variables.
xsteadfastx self-assigned this 2020-12-09 08:21:18 +01:00
xsteadfastx manually merged commit 82e99c032b into master 2020-12-09 08:38:29 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
xsteadfastx
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xsteadfastx/jellyfixer#1
No description provided.
Delete Branch "Koma-Andrea/jellyfixer:typeinsteadmap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?