Commit Graph

2843 Commits

Author SHA1 Message Date
Paweł Szulik
dafbfa54dc Add cgroups v2 support for perf events.
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
2020-06-16 13:18:04 +02:00
David Ashpole
107e5aa4c3
Merge pull request #2558 from AlexeyPerevalov/socket_id
Fix test with different order of Topology's nodes
2020-05-26 15:26:18 -07:00
David Ashpole
92f31e79a7
Merge pull request #2556 from gaurav1086/oomparser_fix_data_race
oomparser_test: fix data race
2020-05-26 13:33:52 -07:00
Alexey Perevalov
2e2a4c496a Fix test with different order of Topology's nodes
GetTopology provides Nodes not in order of Node.Id.
PR https://github.com/google/cadvisor/pull/2551 removed that check,
as result test acidentially passed.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
2020-05-26 21:32:12 +03:00
Gaurav Singh
7df66d30ec Fix build errors
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-26 14:03:57 -04:00
David Ashpole
12c678119a
Merge pull request #2554 from katarzyna-z/kk-running-docs
Information about running cAdvisor without privileged option
2020-05-26 09:51:15 -07:00
David Ashpole
7de12532ec
Merge pull request #2553 from dashpole/docs_update
Add /dev/kmsg to docker example
2020-05-26 09:49:50 -07:00
David Ashpole
c481d7c60c
Merge pull request #2551 from AlexeyPerevalov/socket_id
Add socket id into Core
2020-05-26 09:48:42 -07:00
Gaurav Singh
83f722be88 oomparser_test: fix data race
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-23 00:11:00 -04:00
Katarzyna Kujawa
a640488bcc Information about running cAdvisor without privileged option
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-22 09:13:17 +02:00
David Ashpole
bfa1f90800 add /dev/kmsg to docker example 2020-05-21 15:58:05 -07:00
David Ashpole
425e2117eb
Merge pull request #2552 from tedyu/subcont-nil-chk
Check container against nil before de-referencing
2020-05-21 15:37:58 -07:00
Ted Yu
1ae6987854 Check container against nil before de-referencing
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-21 15:28:59 -07:00
David Ashpole
9253ce057a
Merge pull request #2469 from giuseppe/update-libcontainer
libcontainer, cgroupv2: adapt to new API
2020-05-21 15:05:41 -07:00
David Ashpole
0c14aab88e
Merge pull request #2540 from ctripcloud/addWarnLogForMissingContainerInfo
fix missing container info when getting sub-containers stats
2020-05-21 09:54:08 -07:00
David Ashpole
43a9bd9d93
Merge pull request #2543 from kshithijiyer/patch-1
Reformat README
2020-05-21 09:52:58 -07:00
Alexey Perevalov
a5e4d35ad3 Add socket id into Core
Now cadvisor in MachineInfo.Topology keeps NUMA nodes.
There is no socket information, except number of sockets.
Since socket - NUMA nodes relationship could be many-to-many,
it's more reasonable to keep socket_id per Core, not per NUMA node.

This socket id could be used in kubernetes cpu manager to provide
per socket allocations.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
2020-05-21 18:07:13 +03:00
David Ashpole
64ac14e2ef
Merge pull request #2549 from gaurav1086/runner_fix_goroutine_leak
runner: fix goroutine leak
2020-05-20 10:18:03 -07:00
Giuseppe Scrivano
ab2da09c28
libcontainer: use inactive_file on cgroup v2
total_inactive_file is present only on cgroup v1

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-05-20 16:07:17 +02:00
Giuseppe Scrivano
6a95c22c20
libcontainer, cgroupv2: adapt to new API
adapt the handlers to use the new libcontainer API for cgroup v2.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-05-20 16:07:16 +02:00
ChenQingya
522e8bcaf5 fix SubcontainersInfo response not recursive bug
Signed-off-by: ChenQingya <qingya.chen520@gmail.com>
2020-05-20 17:19:24 +08:00
Gaurav Singh
4819f60acf runner: fix goroutine leak
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-19 21:44:15 -04:00
David Ashpole
f28cda1a21
Merge pull request #2547 from dashpole/integration_flake
Lengthen timeout and add additional information for debugging flakes
2020-05-18 12:44:56 -07:00
David Ashpole
241260f47d lengthen timeout and add additional information for debugging flakes 2020-05-18 12:24:13 -07:00
David Ashpole
3f032baf42
Merge pull request #2546 from google/dashpole-patch-1
update canary job to go 1.14
2020-05-18 10:39:13 -07:00
David Ashpole
40c154a479
update canary job to go 1.14 2020-05-18 10:20:55 -07:00
David Ashpole
050551287c
Merge pull request #2545 from dashpole/privileged
add --privileged to example to readme
2020-05-15 09:45:21 -07:00
ChenQingya
e8da0d53f0 add unit test cases for Getting subcontainers info if scans with more subcontainers
Signed-off-by: ChenQingya <qingya.chen520@gmail.com>
2020-05-15 11:49:05 +08:00
David Ashpole
86996fb59b add --privileged to example to readme 2020-05-14 15:56:18 -07:00
David Ashpole
6a8d61401e
Merge pull request #2513 from iwankgb/deprecated_grpc.WithDialer
Getting rid of depracated grpc function calls
2020-05-13 09:07:41 -07:00
Kshithij Iyer
eaeb7d9651
Updating README.md file 2020-05-13 16:37:49 +05:30
ChenQingya
5b50575a84 add warn log for missing container info when getting sub-containers stats
Signed-off-by: ChenQingya <qingya.chen520@gmail.com>
2020-05-12 16:20:39 +08:00
David Ashpole
889f677da3
Merge pull request #2521 from katarzyna-z/kk-remove-binary
Remove golangci-lint binary from repository
2020-05-11 09:11:45 -07:00
David Ashpole
951ce62d42
Merge pull request #2538 from ymyzk/patch-1
Fix description of cpu_cores metrics in docs
2020-05-11 09:11:20 -07:00
Yusuke Miyazaki
c125cd9b92 Fix description of cpu_cores metrics
The description of machine_cpu_cores and machine_cpu_physical_cores was swapped.
2020-05-09 00:48:22 +09:00
David Ashpole
a35d53a390
Merge pull request #2535 from giuseppe/fix-machine-test
machine, topology_test: not read system file
2020-05-07 17:16:18 -07:00
Giuseppe Scrivano
bf311ce408
machine, topology_test: not read system file
GetClockSpeed() uses the information from the file
/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq when it exists.

Make sure it is not used for tests.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-05-06 09:23:17 +02:00
Maciej "Iwan" Iwanowski
4cf2f01ac8 Incomplete attement to get rid of grpc deprecation warnings
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@critical.today>
2020-05-04 21:21:19 +02:00
David Ashpole
414043db03
Merge pull request #2527 from katarzyna-z/kk-fix-perf-documentation
Add documentation for building and running cAdvisor with perf support
2020-05-04 10:02:52 -07:00
iwankgb
a470ec166c
Some linting errors (#2532)
* Fixing number of linting errors

Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-05-04 10:01:35 -07:00
iwankgb
3d9cf1cbed
Using upstream golangci-lint (#2531)
* Using upstream golangci-lint

Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-05-04 09:56:58 -07:00
Katarzyna Kujawa
ba7b51b5f2 Add documentation for building and running cAdvisor with perf support
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-04 10:29:38 +02:00
Guo Jianwei
430d7cf7fc
Fix GetClockSpeed error when dealing with upper case (#2517)
* Fix GetClockSpeed error when dealing with upper case

Signed-off-by: sayaoailun <guojianwei007@126.com>
2020-05-01 11:24:44 -07:00
David Ashpole
4f0c692951
Merge pull request #2528 from katarzyna-z/kk-fix-kustomize
Fix generating daemonset with example patches using Kustomize
2020-05-01 11:22:37 -07:00
Katarzyna Kujawa
ae129c9455 Fix generating daemonset with example patches using Kustomize
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-04-30 15:58:46 +02:00
David Ashpole
438d294d3b
Merge pull request #2524 from piowag/hugetlb-documentation
Add hugetlb metrics to prometheus metrics documentation
2020-04-29 11:58:38 -07:00
Katarzyna Kujawa
738f136b2b
Introduce new machine metrics: (#2519)
* Introduce new machine metrics:
- machine_cpu_cache_capacity_bytes
- machine_node_hugepages_count
- machine_node_memory_capacity_bytes
- machine_nvm_avg_power_budget_watts
- machine_thread_siblings_count

Introduce timestamp for machine related information

Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-04-29 11:58:23 -07:00
David Ashpole
1cbd3c7c58
Merge pull request #2518 from katarzyna-z/kk-remove-go-cmp
Remove go-cmp from from cache comparison
2020-04-29 11:51:58 -07:00
Piotr Wagner
3e469c38b5 Added hugetlb metrics to prometheus metrics documentation
Signed-off-by: Piotr Wagner <piotr.wagner@intel.com>
2020-04-29 14:25:06 +02:00
Katarzyna Kujawa
09c98f59a9 Remove go-cmp from from cache comparison
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-04-29 11:55:43 +02:00