Commit Graph

2384 Commits

Author SHA1 Message Date
Valentyn Boginskey
b09b68c4a9 Fix cache reporting with cgroup hierarchy 2018-07-28 07:20:42 -04:00
Xander Grzywinski
a390d2ef0c statsd docs (Issue #2002) (#2005)
* statsd documentation
2018-07-27 12:57:48 -07:00
David Ashpole
6147978e03
Merge pull request #2004 from wgliang/master
Fix panic when querying prometheus endpoint
2018-07-19 14:16:09 -07:00
Guoliang Wang
910de81342 Check the length before using container.Stats 2018-07-19 13:40:26 +08:00
Luc Perkins
97fcafeb0b Add table listing Prometheus metrics to Prometheus doc (#2001)
Add prometheus docs metrics table
2018-07-13 14:15:53 -07:00
David Ashpole
f7576313bd
Merge pull request #1980 from dashpole/ignore_metrics
Don't emit prometheus metrics for metrics that are disabled
2018-07-09 13:58:14 -07:00
David Ashpole
c225d06adf don't emit prometheus metrics that are ignored 2018-07-09 13:17:49 -07:00
David Ashpole
01ef7f1fc3
Merge pull request #1979 from dashpole/daemonset
Add cadvisor daemonset using kustomize
2018-07-04 10:22:13 -07:00
David Ashpole
98283308f9
Merge pull request #1984 from jaloren/filter_docker_prom_mets
Control whether container labels are exported as prometheus metrics.
2018-07-04 10:11:43 -07:00
David Ashpole
28c3221262
Merge pull request #1985 from lichuqiang/master
Return best-effort result when AllDockerContainers hits the cache not synced issue
2018-07-04 09:49:06 -07:00
Joseph Lorenzini
4bd335b8fd Control whether container labels are exported as prometheus metrics.
when cadvisor exports metrics for docker containers, there is a root cgroup (/) and cgroup for a docker container (/docker/uuid).
If docker container has a label on it, then this label is applied to all containers including the root container.
Because some containers don't have that label, the label will have an empty value. The reason for this is that Prometheus
does not allow sending a metric with the same name, but different labels, so cadvisor uses empty label values based on
the set of all labels for a given metric. This can result in many docker containers getting a large number of empty labels
because another container has that label.

If large number of docker labels vary a lot across images, then the set of labels will be enormous, where most of the labels
will be empty and have no value as prometheus metrics. To avoid this problem, a flag is provided that allows a user to
disable exporting docker labels as metrics.
2018-07-04 10:53:08 -05:00
lichuqiang
791138b01e Return best-effort result when AllDockerContainers hits the cache not synced issue 2018-07-04 09:58:48 +08:00
David Ashpole
7a52d9dc51 add kubernetes daemonset for cAdvisor 2018-07-03 13:01:18 -07:00
David Ashpole
ccda2eadc5
Merge pull request #1965 from sashankreddya/mesos_containerizer_support
Add mesos containerizer support
2018-06-28 15:16:36 -07:00
Sashank Appireddy
ff8c1e80df Add dependencies needed for mesos containerizer 2018-06-28 22:07:55 +00:00
Sashank Appireddy
ed0e3f0f43 Add mesos containerizer support
This commit includes support for collecting container stats
launched by mesos containerizer.
2018-06-28 22:07:55 +00:00
David Ashpole
2df69b73de
Merge pull request #1983 from moooofly/develop
fix: ./deploy/build.sh can not find Dockerfile
2018-06-28 10:04:55 -07:00
moooofly
8630f1d855 fix: update docs/deploy.md 2018-06-28 16:00:45 +08:00
moooofly
f760e2b4d6 fix: ./deploy/build.sh can not find Dockerfile 2018-06-28 15:30:37 +08:00
David Ashpole
b1535b8a39
Merge pull request #1926 from andyxning/add_docker-only_whitelist
add docker_only_prefix_whitelist
2018-06-21 11:27:17 -07:00
David Ashpole
179330dca5
Merge pull request #1971 from MaximilianMeister/fix-kubernetes-issue-65204
fix brtfs issue where dir is sub-directory of a sub-volume
2018-06-20 09:40:21 -07:00
Maximilian Meister
87ddb0e041
fix kubernetes issue #65204
https://github.com/kubernetes/kubernetes/issues/65204

Signed-off-by: Maximilian Meister <mmeister@suse.de>
2018-06-19 08:28:30 +02:00
David Ashpole
fc0bd7a170
Merge pull request #1969 from mindprince/fix-race
Initialize NVML on demand.
2018-06-18 10:55:01 -07:00
Rohit Agarwal
2ce41611a0 Initialize NVML on demand.
Earlier if the NVIDIA driver was not installed when cAdvisor was started
we would start a goroutine to try to initialize NVML every minute.

This resulted in a race. We can have a situation where:
- goroutine tries to initialize NVML but fails. So, it sleeps for a minute.
- the driver is installed.
- a container that uses NVIDIA devices is started.
This container would not get GPU stats because a minute has not passed
since the last failed initialization attempt and so NVML is not
initialized.
2018-06-18 10:45:40 -07:00
David Ashpole
f834c0f4c1
Merge pull request #1967 from jessfraz/vendor
vendor: update docker import
2018-06-14 15:06:04 -07:00
Jess Frazelle
d7df66e4eb
vendor: update docker import
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
2018-06-14 17:54:41 -04:00
David Ashpole
198bf16d0f
Merge pull request #1964 from dashpole/dont_watch_mount
Dont watch "*.mount" cgroups
2018-06-14 10:38:10 -07:00
David Ashpole
bc7e1cbb4f dont watch .mount cgroups 2018-06-14 10:17:50 -07:00
David Ashpole
9373cb25c0
Merge pull request #1963 from runcom/fix-race-cntr-handlers
container: fix concurrent map acccess
2018-06-13 10:39:11 -07:00
Antonio Murdaca
42eeba5783
container: fix concurrent map acccess
GetSpec() can be called concurrently in
manager/container.go.updateSpec()
results into a concurrent map access on the labels map because we're
directly updating the map inside GetSpec(). The labels map from the
container handler is not a copy of the map itself, just a reference,
that's why we're getting the concurrent map access.
Fix this by moving the label update with restartcount to the handler's
initialization method which is not called concurrently.

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2018-06-13 19:06:47 +02:00
David Ashpole
e10baf0057
Merge pull request #1961 from dashpole/cherrypick_1959
Revert "Switch from Inotify to Fsnotify"
2018-06-11 11:16:12 -07:00
David Ashpole
fdcae5552b Revert "Switch from Inotify to Fsnotify"
This reverts commit c1a6d6090b.
2018-06-11 11:15:30 -07:00
David Ashpole
dbbfeacf28
Merge pull request #1960 from dashpole/changelog_v0.30.1
changelog for v0.30.1
2018-06-11 11:02:36 -07:00
David Ashpole
a244c6a17b
Merge pull request #1959 from dashpole/revert_fsnotify
Revert "Switch from Inotify to Fsnotify"
2018-06-11 11:02:14 -07:00
David Ashpole
bdb8e3edea changelog for v0.30.1 2018-06-11 10:58:59 -07:00
David Ashpole
8335af9d6b Revert "Switch from Inotify to Fsnotify"
This reverts commit c1a6d6090b.
2018-06-11 10:50:23 -07:00
David Ashpole
f6359ffcbd
Merge pull request #1952 from dashpole/changelog
v0.30.0 changelog
2018-06-05 11:06:47 -07:00
David Ashpole
7855a7f180 v0.30.0 changelog 2018-06-05 10:59:19 -07:00
David Ashpole
b343856a24
Merge pull request #1949 from ElfoLiNk/dockerfile
Update Dockerfile and dependencies
2018-05-29 14:13:34 -07:00
Matteo Gazzetta
c1f1e59cf9 Update Dockerfile and dependencies 2018-05-29 22:53:13 +02:00
David Ashpole
33a72c6b8b
Merge pull request #1940 from dims/run-find-command-with-nice-to-reduce-cpu-load
Run find command with nice to reduce cpu load
2018-05-08 14:30:38 -07:00
Davanum Srinivas
29203d62e9 Run find command with nice+ionice to reduce cpu / io
Reduce impact of running the "find" command when system is loaded. We
already use "nice" and "ionice" with the "du" command.
2018-05-08 16:32:39 -04:00
David Ashpole
96b62ed83b
Merge pull request #1939 from dims/run-du-with-ionice
Run du with ionice
2018-05-08 09:32:03 -07:00
Davanum Srinivas
47a5869161 Run du with ionice
Let us run du with idle io priority
2018-05-08 10:51:30 -04:00
David Ashpole
804cd3c133
Merge pull request #1934 from sjenning/fix-os-release-parsing
Fix os release parsing
2018-04-20 10:41:33 -07:00
Seth Jennings
a88f575eb0 use more robust docker os-release parser 2018-04-20 12:22:50 -05:00
Seth Jennings
8c28d09dbf deps: add docker operatingsystems package 2018-04-20 12:22:44 -05:00
David Ashpole
7ce8450e51
Merge pull request #1877 from bhuvanchandra/master
cadvisor: build: fix broken build with Makefile
2018-04-18 10:53:50 -07:00
David Ashpole
853f966095
Merge pull request #1927 from mavidser/patch-1
Update docs - go 1.7 needed for building
2018-04-18 10:42:17 -07:00
David Ashpole
26fc1eb689
Merge pull request #1930 from mariusbld/mariusbld/fix-kafka-logs
Enable kafka logs when using kafka storage driver
2018-04-18 08:44:18 -07:00