Commit Graph

2423 Commits

Author SHA1 Message Date
Sashank Appireddy
02ecf721f5 Emit number of processes and file descriptors of a container 2018-10-29 16:55:34 -07:00
Sashank Appireddy
026bc840e1 Merge remote-tracking branch 'upstream/master' 2018-10-29 16:54:40 -07:00
David Ashpole
32b5c68765
Merge pull request #2081 from dashpole/go_1.11
Update formatting for go 1.11
2018-10-29 11:25:09 -07:00
David Ashpole
d44ade2927 make formatting compatible with 1.11, and revert #2056 2018-10-23 11:28:14 -07:00
Sashank Appireddy
d0df79e237 Merge remote-tracking branch 'upstream/master' 2018-10-22 11:57:22 -07:00
Yann Hodique
d8cdae8022 replace golang.org/x/exp/inotify with standalone library
context: kubernetes/kubernetes#68478

The inotify code was removed from golang.org/x/exp several years ago. Therefore
importing it from that path prevents downstream consumers from using any module
that makes use of more recent features of golang.org/x/exp.

Given that this code is by definition frozen and that the long term path should
be to migrate to fsnotify, replacing the current code by an identical standalone
copy doesn't have maintenance cost, and will unlock other activities for
kubernetes for example.
2018-10-22 11:53:17 -07:00
David Ashpole
c5510abcd7
Merge pull request #2060 from sigma/pr/inotify
replace golang.org/x/exp/inotify with standalone library
2018-10-19 15:35:21 -07:00
David Ashpole
43a86a3cb9
Merge pull request #2063 from Omnition/selector
Add required selector option to daemonset
2018-10-04 15:22:45 -07:00
Steve Flanders
614478fd5f Add required selector option to daemonset
Fixes #2062
2018-10-04 14:44:38 -07:00
David Ashpole
49e7c7ead4
Merge pull request #2058 from warmchang/patch-1
fix spelling errors
2018-10-03 14:03:36 -07:00
Yann Hodique
289e560efd replace golang.org/x/exp/inotify with standalone library
context: kubernetes/kubernetes#68478

The inotify code was removed from golang.org/x/exp several years ago. Therefore
importing it from that path prevents downstream consumers from using any module
that makes use of more recent features of golang.org/x/exp.

Given that this code is by definition frozen and that the long term path should
be to migrate to fsnotify, replacing the current code by an identical standalone
copy doesn't have maintenance cost, and will unlock other activities for
kubernetes for example.
2018-09-28 08:48:12 -07:00
William Zhang
7961198a0c fix spelling errors
Signed-off-by: William Zhang <zhang.wanmin@zte.com.cn>
2018-09-28 15:49:25 +08:00
David Ashpole
e7c0798314
Merge pull request #2055 from dims/avoid-too-many-errors-when-mesos-is-absent
Avoid too many mesos errors in logs when mesos is not present
2018-09-26 15:36:21 -07:00
David Ashpole
f633448066
Merge pull request #2054 from sashankreddya/rename_memory_failure_label
Rename extraLabel "type" to "failure_type" for memory_failures_total
2018-09-26 14:53:55 -07:00
David Ashpole
9ab298228a
Merge pull request #2056 from dashpole/fix_build
Use go1.10 for canary builds
2018-09-26 14:50:10 -07:00
David Ashpole
34427f02be use go1.10 to build the canary image 2018-09-26 14:41:06 -07:00
Davanum Srinivas
344f728393
Avoid too many mesos errors in logs when mesos is not present
We see a lot of logs in k/k CI as follows:
"Factory "mesos" was unable to handle container "/system.slice/home-kubernetes-containerized_mounter.mount"

It would be better if we do some sanity check for mesos running before
we try to use it.

Change-Id: I5f6ebcd44fdd4f8d724b85857edf1600473ef1ab
2018-09-26 16:41:32 -04:00
Sashank Appireddy
e98f28b7c0 Rename extraLabel "type" to "failure_type" for memory_failures_total 2018-09-26 18:25:54 +00:00
David Ashpole
be9cd931d7
Merge pull request #2044 from sashankreddya/sashank_mesos_containers_fix
Ensure that empty mesos containers reference as a failure to fetch containers
2018-09-18 16:13:36 -07:00
Sashank Appireddy
ec4f24ebd4 Ensure that empty mesos containers reference as a failure to fetch containers 2018-09-14 15:31:50 +05:30
Yann Hodique
b36e6fb63a fix minor errors revealed by go 1.11 (#2039)
minor fixes for go 1.11
2018-09-10 13:49:37 -07:00
David Ashpole
fc17731afd
Merge pull request #2038 from dashpole/v0.31.0_changelog
v0.31.0 changelog
2018-09-07 16:04:42 -07:00
David Ashpole
fd409228c1 v0.31.0 changelog 2018-09-07 14:35:19 -07:00
Mikhail Shaverdo
fcc77c654b Get rid of lock during list containers (#2024)
* Get rid of lock during list containers
2018-08-29 13:06:28 -07:00
David Ashpole
2fa6c624a2
Merge pull request #2034 from usabilla/mapped_file
Adds mapped_file metric
2018-08-29 10:25:29 -07:00
Gijs Kunze
8a789bb1cd Adds missing documentation for container_memory_mapped_files 2018-08-29 10:05:28 +02:00
David Ashpole
3e657b4b5e
Merge pull request #2033 from mannychang/master
Update glibc version to 2.28-r0
2018-08-28 09:37:51 -07:00
Manny Chang
e233075682 Update Dockerfile and dependencies 2018-08-28 16:48:06 +08:00
David Ashpole
03b0cc3b9d
Merge pull request #2029 from dashpole/update_security
Update documentation to make /var/run read-only
2018-08-22 15:38:00 -07:00
David Ashpole
d1b3158fa5 update documentation to make /var/run read-only, and add /dev/disk to the kustomize base 2018-08-21 17:39:56 -07:00
Becca Powell
eb02a5e941 fix a few things in the readme (#2025)
* small readme improvements
2018-08-21 10:58:35 -07:00
David Ashpole
d8d7bf8b2d
Merge pull request #2014 from grnhse/use-hierarchy-for-cache
Fix cache reporting with cgroup hierarchy
2018-08-15 14:48:01 -07:00
David Ashpole
015bce60a7
Merge pull request #2006 from eklitzke/statfs
Lower log verbosity for statfs failures, fixes #1772
2018-08-15 14:47:25 -07:00
David Ashpole
820ba9baf1
Merge pull request #2021 from zhangjianweibj/networkudpmetrics
networkUdpMetrics error if condition
2018-08-15 14:14:53 -07:00
zhangjianweibj
cb8a808089 networkUdpMetrics error if condition 2018-08-15 14:58:02 +08:00
Gijs Kunze
9e175e9ea9 Adds mapped_file metric 2018-08-09 15:14:46 +02:00
David Ashpole
18afaa921b
Merge pull request #2010 from sashankreddya/test_mesos_branch
Ensure that labels for mesos tasks launched via MesosCommandExecutor are collected
2018-08-02 17:27:35 -07:00
Sashank Appireddy
2c96ceb478 Ensure that labels for mesos tasks launched via MesosCommandExecutor
are collected as well
2018-08-01 17:52:51 -07:00
Valentyn Boginskey
b09b68c4a9 Fix cache reporting with cgroup hierarchy 2018-07-28 07:20:42 -04:00
Xander Grzywinski
a390d2ef0c statsd docs (Issue #2002) (#2005)
* statsd documentation
2018-07-27 12:57:48 -07:00
Evan Klitzke
f31f580d9c
Lower log verbosity for statfs failures, fixes #1772 2018-07-20 15:26:52 -07:00
David Ashpole
6147978e03
Merge pull request #2004 from wgliang/master
Fix panic when querying prometheus endpoint
2018-07-19 14:16:09 -07:00
Guoliang Wang
910de81342 Check the length before using container.Stats 2018-07-19 13:40:26 +08:00
Luc Perkins
97fcafeb0b Add table listing Prometheus metrics to Prometheus doc (#2001)
Add prometheus docs metrics table
2018-07-13 14:15:53 -07:00
David Ashpole
f7576313bd
Merge pull request #1980 from dashpole/ignore_metrics
Don't emit prometheus metrics for metrics that are disabled
2018-07-09 13:58:14 -07:00
David Ashpole
c225d06adf don't emit prometheus metrics that are ignored 2018-07-09 13:17:49 -07:00
David Ashpole
01ef7f1fc3
Merge pull request #1979 from dashpole/daemonset
Add cadvisor daemonset using kustomize
2018-07-04 10:22:13 -07:00
David Ashpole
98283308f9
Merge pull request #1984 from jaloren/filter_docker_prom_mets
Control whether container labels are exported as prometheus metrics.
2018-07-04 10:11:43 -07:00
David Ashpole
28c3221262
Merge pull request #1985 from lichuqiang/master
Return best-effort result when AllDockerContainers hits the cache not synced issue
2018-07-04 09:49:06 -07:00
Joseph Lorenzini
4bd335b8fd Control whether container labels are exported as prometheus metrics.
when cadvisor exports metrics for docker containers, there is a root cgroup (/) and cgroup for a docker container (/docker/uuid).
If docker container has a label on it, then this label is applied to all containers including the root container.
Because some containers don't have that label, the label will have an empty value. The reason for this is that Prometheus
does not allow sending a metric with the same name, but different labels, so cadvisor uses empty label values based on
the set of all labels for a given metric. This can result in many docker containers getting a large number of empty labels
because another container has that label.

If large number of docker labels vary a lot across images, then the set of labels will be enormous, where most of the labels
will be empty and have no value as prometheus metrics. To avoid this problem, a flag is provided that allows a user to
disable exporting docker labels as metrics.
2018-07-04 10:53:08 -05:00