From 043b7e8013674d58757fe3d3f4e4cacf89c46112 Mon Sep 17 00:00:00 2001 From: Simon Rozman Date: Thu, 7 Feb 2019 20:49:41 +0100 Subject: [PATCH] wintun: Clean excessive setupapi.DevInfo.GetDeviceInfoListDetail() call Signed-off-by: Simon Rozman --- tun/wintun/wintun_windows.go | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/tun/wintun/wintun_windows.go b/tun/wintun/wintun_windows.go index c1ffb17..75180d5 100644 --- a/tun/wintun/wintun_windows.go +++ b/tun/wintun/wintun_windows.go @@ -45,13 +45,6 @@ func GetInterface(ifname string, hwndParent uintptr) (*Wintun, error) { } defer devInfoList.Close() - // Retrieve information associated with a device information set. - // TODO: Is this really necessary? - _, err = devInfoList.GetDeviceInfoListDetail() - if err != nil { - return nil, err - } - // Windows requires each interface to have a different name. When // enforcing this, Windows treats interface names case-insensitive. If an // interface "FooBar" exists and this function reports there is no @@ -266,13 +259,6 @@ func (wintun *Wintun) DeleteInterface(hwndParent uintptr) (bool, bool, error) { } defer devInfoList.Close() - // Retrieve information associated with a device information set. - // TODO: Is this really necessary? - _, err = devInfoList.GetDeviceInfoListDetail() - if err != nil { - return false, false, err - } - // Iterate. for index := 0; ; index++ { // Get the device from the list.