xsteadfastx/conventionalcommits.org
1
0
Fork 0
mirror of https://github.com/conventional-commits/conventionalcommits.org.git synced 2024-11-15 02:45:15 +01:00
Code Issues Projects Releases Wiki Activity

fix: replace "refactor!" with "feat!" (#350)

Browse Source 
Refactoring by definition "is the process of changing a software system in such a way that it does not alter the external behavior of the code..." So, a refactoring cannot introduce a breaking change, otherwise it is not a refactoring anymore. Using `refactor` commit type and the breaking change marker `!` is a contradiction.
This commit is contained in:
Sergiy Kolesnikov 2021-03-17 16:43:31 +01:00 committed by GitHub
parent f0aeba39f8
commit 2a5f0308c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
content/next/index.md
View File

@ -53,14 +53,14 @@ BREAKING CHANGE: `extends` key in config file is now used for extending other co
### Commit message with `!` to draw attention to breaking change
```
refactor!: drop support for Node 6
feat!: drop support for Node 6
```
### Commit message with both `!` and BREAKING CHANGE footer
```
refactor!: drop support for Node 6
feat!: drop support for Node 6
BREAKING CHANGE: refactor to use JavaScript features not available in Node 6.
BREAKING CHANGE: use JavaScript features not available in Node 6.
```
### Commit message with no body