Remove spec-related fields from stat. We can simplify the stats a bit further by handling Int and Float better. But this was big enough change already. Verified v1 and v2 spec/stats/appmetrics APIs.
168 lines
5.1 KiB
Go
168 lines
5.1 KiB
Go
// Copyright 2015 Google Inc. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package collector
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/google/cadvisor/info/v1"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestEmptyConfig(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
emptyConfig := `
|
|
{
|
|
"endpoint" : "http://localhost:8000/nginx_status",
|
|
"metrics_config" : [
|
|
]
|
|
}
|
|
`
|
|
|
|
//Create a temporary config file 'temp.json' with invalid json format
|
|
assert.NoError(ioutil.WriteFile("temp.json", []byte(emptyConfig), 0777))
|
|
|
|
configFile, err := ioutil.ReadFile("temp.json")
|
|
assert.NoError(err)
|
|
|
|
_, err = NewCollector("tempCollector", configFile)
|
|
assert.Error(err)
|
|
|
|
assert.NoError(os.Remove("temp.json"))
|
|
}
|
|
|
|
func TestConfigWithErrors(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
//Syntax error: Missed '"' after activeConnections
|
|
invalid := `
|
|
{
|
|
"endpoint" : "http://localhost:8000/nginx_status",
|
|
"metrics_config" : [
|
|
{
|
|
"name" : "activeConnections,
|
|
"metric_type" : "gauge",
|
|
"units" : "integer",
|
|
"polling_frequency" : 10,
|
|
"regex" : "Active connections: ([0-9]+)"
|
|
}
|
|
]
|
|
}
|
|
`
|
|
|
|
//Create a temporary config file 'temp.json' with invalid json format
|
|
assert.NoError(ioutil.WriteFile("temp.json", []byte(invalid), 0777))
|
|
configFile, err := ioutil.ReadFile("temp.json")
|
|
assert.NoError(err)
|
|
|
|
_, err = NewCollector("tempCollector", configFile)
|
|
assert.Error(err)
|
|
|
|
assert.NoError(os.Remove("temp.json"))
|
|
}
|
|
|
|
func TestConfigWithRegexErrors(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
//Error: Missed operand for '+' in activeConnections regex
|
|
invalid := `
|
|
{
|
|
"endpoint" : "host:port/nginx_status",
|
|
"metrics_config" : [
|
|
{
|
|
"name" : "activeConnections",
|
|
"metric_type" : "gauge",
|
|
"units" : "integer",
|
|
"polling_frequency" : 10,
|
|
"regex" : "Active connections: (+)"
|
|
},
|
|
{
|
|
"name" : "reading",
|
|
"metric_type" : "gauge",
|
|
"units" : "integer",
|
|
"polling_frequency" : 10,
|
|
"regex" : "Reading: ([0-9]+) .*"
|
|
}
|
|
]
|
|
}
|
|
`
|
|
|
|
//Create a temporary config file 'temp.json'
|
|
assert.NoError(ioutil.WriteFile("temp.json", []byte(invalid), 0777))
|
|
|
|
configFile, err := ioutil.ReadFile("temp.json")
|
|
assert.NoError(err)
|
|
|
|
_, err = NewCollector("tempCollector", configFile)
|
|
assert.Error(err)
|
|
|
|
assert.NoError(os.Remove("temp.json"))
|
|
}
|
|
|
|
func TestConfig(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
//Create an nginx collector using the config file 'sample_config.json'
|
|
configFile, err := ioutil.ReadFile("config/sample_config.json")
|
|
assert.NoError(err)
|
|
|
|
collector, err := NewCollector("nginx", configFile)
|
|
assert.NoError(err)
|
|
assert.Equal(collector.name, "nginx")
|
|
assert.Equal(collector.configFile.Endpoint, "http://localhost:8000/nginx_status")
|
|
assert.Equal(collector.configFile.MetricsConfig[0].Name, "activeConnections")
|
|
}
|
|
|
|
func TestMetricCollection(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
//Collect nginx metrics from a fake nginx endpoint
|
|
configFile, err := ioutil.ReadFile("config/sample_config.json")
|
|
assert.NoError(err)
|
|
|
|
fakeCollector, err := NewCollector("nginx", configFile)
|
|
assert.NoError(err)
|
|
|
|
tempServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
fmt.Fprintln(w, "Active connections: 3\nserver accepts handled requests")
|
|
fmt.Fprintln(w, "5 5 32\nReading: 0 Writing: 1 Waiting: 2")
|
|
}))
|
|
defer tempServer.Close()
|
|
fakeCollector.configFile.Endpoint = tempServer.URL
|
|
|
|
metrics := map[string]v1.MetricVal{}
|
|
_, metrics, errMetric := fakeCollector.Collect(metrics)
|
|
assert.NoError(errMetric)
|
|
metricNames := []string{"activeConnections", "reading", "writing", "waiting"}
|
|
// activeConnections = 3
|
|
assert.Equal(metrics[metricNames[0]].IntValue, 3)
|
|
assert.Equal(metrics[metricNames[0]].FloatValue, 0)
|
|
// reading = 0
|
|
assert.Equal(metrics[metricNames[1]].IntValue, 0)
|
|
assert.Equal(metrics[metricNames[1]].FloatValue, 0)
|
|
// writing = 1
|
|
assert.Equal(metrics[metricNames[2]].IntValue, 1)
|
|
assert.Equal(metrics[metricNames[2]].FloatValue, 0)
|
|
// waiting = 2
|
|
assert.Equal(metrics[metricNames[3]].IntValue, 2)
|
|
assert.Equal(metrics[metricNames[3]].FloatValue, 0)
|
|
}
|