cadvisor/machine/topology_test.go
Katarzyna Kujawa c5a9232a94 Modify GetTopology to read information only from sysfs
* Move sysfs related functions needed to get nodes' information and tests into utils/sysfs
* Add tests for sysfs related functions

Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-03-17 08:44:58 +01:00

308 lines
9.1 KiB
Go

// Copyright 2014 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package machine
import (
"encoding/json"
"io/ioutil"
"os"
"reflect"
"testing"
info "github.com/google/cadvisor/info/v1"
"github.com/google/cadvisor/utils/sysfs"
"github.com/google/cadvisor/utils/sysfs/fakesysfs"
"github.com/stretchr/testify/assert"
)
func TestPhysicalCores(t *testing.T) {
testfile := "./testdata/cpuinfo"
testcpuinfo, err := ioutil.ReadFile(testfile)
assert.Nil(t, err)
assert.NotNil(t, testcpuinfo)
numPhysicalCores := GetPhysicalCores(testcpuinfo)
assert.Equal(t, 6, numPhysicalCores)
}
func TestPhysicalCoresReadingFromCpuBus(t *testing.T) {
cpuBusPath = "./testdata/" // overwriting package variable to mock sysfs
testfile := "./testdata/cpuinfo_arm" // mock cpuinfo without core id
testcpuinfo, err := ioutil.ReadFile(testfile)
assert.Nil(t, err)
assert.NotNil(t, testcpuinfo)
numPhysicalCores := GetPhysicalCores(testcpuinfo)
assert.Equal(t, 2, numPhysicalCores)
}
func TestPhysicalCoresFromWrongSysFs(t *testing.T) {
cpuBusPath = "./testdata/wrongsysfs" // overwriting package variable to mock sysfs
testfile := "./testdata/cpuinfo_arm" // mock cpuinfo without core id
testcpuinfo, err := ioutil.ReadFile(testfile)
assert.Nil(t, err)
assert.NotNil(t, testcpuinfo)
numPhysicalCores := GetPhysicalCores(testcpuinfo)
assert.Equal(t, 0, numPhysicalCores)
}
func TestSockets(t *testing.T) {
testfile := "./testdata/cpuinfo"
testcpuinfo, err := ioutil.ReadFile(testfile)
assert.Nil(t, err)
assert.NotNil(t, testcpuinfo)
numSockets := GetSockets(testcpuinfo)
assert.Equal(t, 2, numSockets)
}
func TestSocketsReadingFromCpuBus(t *testing.T) {
cpuBusPath = "./testdata/wrongsysfs" // overwriting package variable to mock sysfs
testfile := "./testdata/cpuinfo_arm" // mock cpuinfo without physical id
testcpuinfo, err := ioutil.ReadFile(testfile)
assert.Nil(t, err)
assert.NotNil(t, testcpuinfo)
numSockets := GetSockets(testcpuinfo)
assert.Equal(t, 0, numSockets)
}
func TestSocketsReadingFromWrongSysFs(t *testing.T) {
cpuBusPath = "./testdata/" // overwriting package variable to mock sysfs
testfile := "./testdata/cpuinfo_arm" // mock cpuinfo without physical id
testcpuinfo, err := ioutil.ReadFile(testfile)
assert.Nil(t, err)
assert.NotNil(t, testcpuinfo)
numSockets := GetSockets(testcpuinfo)
assert.Equal(t, 1, numSockets)
}
func TestTopology(t *testing.T) {
machineArch = "" // overwrite package variable
sysFs := &fakesysfs.FakeSysFs{}
c := sysfs.CacheInfo{
Size: 32 * 1024,
Type: "unified",
Level: 1,
Cpus: 2,
}
sysFs.SetCacheInfo(c)
nodesPaths := []string{
"/fakeSysfs/devices/system/node/node0",
"/fakeSysfs/devices/system/node/node1",
}
sysFs.SetNodesPaths(nodesPaths, nil)
cpusPaths := map[string][]string{
"/fakeSysfs/devices/system/node/node0": {
"/fakeSysfs/devices/system/node/node0/cpu0",
"/fakeSysfs/devices/system/node/node0/cpu1",
"/fakeSysfs/devices/system/node/node0/cpu2",
"/fakeSysfs/devices/system/node/node0/cpu6",
"/fakeSysfs/devices/system/node/node0/cpu7",
"/fakeSysfs/devices/system/node/node0/cpu8",
},
"/fakeSysfs/devices/system/node/node1": {
"/fakeSysfs/devices/system/node/node0/cpu3",
"/fakeSysfs/devices/system/node/node0/cpu4",
"/fakeSysfs/devices/system/node/node0/cpu5",
"/fakeSysfs/devices/system/node/node0/cpu9",
"/fakeSysfs/devices/system/node/node0/cpu10",
"/fakeSysfs/devices/system/node/node0/cpu11",
},
}
sysFs.SetCPUsPaths(cpusPaths, nil)
coreThread := map[string]string{
"/fakeSysfs/devices/system/node/node0/cpu0": "0",
"/fakeSysfs/devices/system/node/node0/cpu1": "1",
"/fakeSysfs/devices/system/node/node0/cpu2": "2",
"/fakeSysfs/devices/system/node/node0/cpu3": "3",
"/fakeSysfs/devices/system/node/node0/cpu4": "4",
"/fakeSysfs/devices/system/node/node0/cpu5": "5",
"/fakeSysfs/devices/system/node/node0/cpu6": "0",
"/fakeSysfs/devices/system/node/node0/cpu7": "1",
"/fakeSysfs/devices/system/node/node0/cpu8": "2",
"/fakeSysfs/devices/system/node/node0/cpu9": "3",
"/fakeSysfs/devices/system/node/node0/cpu10": "4",
"/fakeSysfs/devices/system/node/node0/cpu11": "5",
}
sysFs.SetCoreThreads(coreThread, nil)
memTotal := "MemTotal: 32817192 kB"
sysFs.SetMemory(memTotal, nil)
hugePages := []os.FileInfo{
&fakesysfs.FileInfo{EntryName: "hugepages-2048kB"},
&fakesysfs.FileInfo{EntryName: "hugepages-1048576kB"},
}
sysFs.SetHugePages(hugePages, nil)
hugePageNr := map[string]string{
"/fakeSysfs/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages": "1",
"/fakeSysfs/devices/system/node/node0/hugepages/hugepages-1048576kB/nr_hugepages": "1",
"/fakeSysfs/devices/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages": "1",
"/fakeSysfs/devices/system/node/node1/hugepages/hugepages-1048576kB/nr_hugepages": "1",
}
sysFs.SetHugePagesNr(hugePageNr, nil)
topology, numCores, err := GetTopology(sysFs)
assert.Nil(t, err)
assert.Equal(t, 12, numCores)
expected_topology := []info.Node{}
numNodes := 2
numCoresPerNode := 3
numThreads := 2
cache := info.Cache{
Size: 32 * 1024,
Type: "unified",
Level: 1,
}
for i := 0; i < numNodes; i++ {
node := info.Node{Id: i}
// Copy over Memory from result. TODO(rjnagal): Use memory from fake.
node.Memory = topology[i].Memory
// Copy over HugePagesInfo from result. TODO(ohsewon): Use HugePagesInfo from fake.
node.HugePages = topology[i].HugePages
for j := 0; j < numCoresPerNode; j++ {
core := info.Core{Id: i*numCoresPerNode + j}
core.Caches = append(core.Caches, cache)
for k := 0; k < numThreads; k++ {
core.Threads = append(core.Threads, k*numCoresPerNode*numNodes+core.Id)
}
node.Cores = append(node.Cores, core)
}
expected_topology = append(expected_topology, node)
}
assert.NotNil(t, reflect.DeepEqual(topology, expected_topology))
}
func TestTopologyEmptySysFs(t *testing.T) {
machineArch = "" // overwrite package variable
_, _, err := GetTopology(&fakesysfs.FakeSysFs{})
assert.NotNil(t, err)
}
func TestTopologyWithNodesWithoutCPU(t *testing.T) {
machineArch = "" // overwrite package variable
sysFs := &fakesysfs.FakeSysFs{}
nodesPaths := []string{
"/fakeSysfs/devices/system/node/node0",
"/fakeSysfs/devices/system/node/node1",
}
sysFs.SetNodesPaths(nodesPaths, nil)
memTotal := "MemTotal: 32817192 kB"
sysFs.SetMemory(memTotal, nil)
hugePages := []os.FileInfo{
&fakesysfs.FileInfo{EntryName: "hugepages-2048kB"},
&fakesysfs.FileInfo{EntryName: "hugepages-1048576kB"},
}
sysFs.SetHugePages(hugePages, nil)
hugePageNr := map[string]string{
"/fakeSysfs/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages": "1",
"/fakeSysfs/devices/system/node/node0/hugepages/hugepages-1048576kB/nr_hugepages": "1",
"/fakeSysfs/devices/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages": "1",
"/fakeSysfs/devices/system/node/node1/hugepages/hugepages-1048576kB/nr_hugepages": "1",
}
sysFs.SetHugePagesNr(hugePageNr, nil)
topology, numCores, err := GetTopology(sysFs)
assert.Nil(t, err)
assert.Equal(t, 0, numCores)
topologyJSON, err := json.Marshal(topology)
assert.Nil(t, err)
expectedTopology := `[
{
"caches": null,
"cores": null,
"hugepages": [
{
"num_pages": 1,
"page_size": 2048
},
{
"num_pages": 1,
"page_size": 1048576
}
],
"memory": 33604804608,
"node_id": 0
},
{
"caches": null,
"cores": null,
"hugepages": [
{
"num_pages": 1,
"page_size": 2048
},
{
"num_pages": 1,
"page_size": 1048576
}
],
"memory": 33604804608,
"node_id": 1
}
]
`
assert.JSONEq(t, expectedTopology, string(topologyJSON))
}
func TestTopologyOnSystemZ(t *testing.T) {
machineArch = "s390" // overwrite package variable
nodes, cores, err := GetTopology(&fakesysfs.FakeSysFs{})
assert.Nil(t, err)
assert.Nil(t, nodes)
assert.NotNil(t, cores)
}
func TestMemoryInfo(t *testing.T) {
testPath := "./testdata/edac/mc"
memory, err := GetMachineMemoryByType(testPath)
assert.Nil(t, err)
assert.Len(t, memory, 2)
assert.Equal(t, uint64(789*1024*1024), memory["Unbuffered-DDR4"].Capacity)
assert.Equal(t, uint64(579*1024*1024), memory["Non-volatile-RAM"].Capacity)
assert.Equal(t, uint(1), memory["Unbuffered-DDR4"].DimmCount)
assert.Equal(t, uint(2), memory["Non-volatile-RAM"].DimmCount)
}
func TestMemoryInfoOnArchThatDoNotExposeMemoryController(t *testing.T) {
testPath := "./there/is/no/spoon"
memory, err := GetMachineMemoryByType(testPath)
assert.Nil(t, err)
assert.Len(t, memory, 0)
}