Commit Graph

139 Commits

Author SHA1 Message Date
Davanum Srinivas
4da6d809be
Move from glog to klog
Change-Id: Ic92f57c2d7f268d8d985797974883c1a537d6993
2018-11-08 18:06:28 -05:00
Yann Hodique
289e560efd replace golang.org/x/exp/inotify with standalone library
context: kubernetes/kubernetes#68478

The inotify code was removed from golang.org/x/exp several years ago. Therefore
importing it from that path prevents downstream consumers from using any module
that makes use of more recent features of golang.org/x/exp.

Given that this code is by definition frozen and that the long term path should
be to migrate to fsnotify, replacing the current code by an identical standalone
copy doesn't have maintenance cost, and will unlock other activities for
kubernetes for example.
2018-09-28 08:48:12 -07:00
Yann Hodique
b36e6fb63a fix minor errors revealed by go 1.11 (#2039)
minor fixes for go 1.11
2018-09-10 13:49:37 -07:00
David Ashpole
8335af9d6b Revert "Switch from Inotify to Fsnotify"
This reverts commit c1a6d6090b.
2018-06-11 10:50:23 -07:00
David Ashpole
c1a6d6090b Switch from Inotify to Fsnotify 2018-04-09 11:09:40 -07:00
Tim Allclair
5b435b4b70
Clean up cAdvisor logging 2017-11-27 19:48:05 -08:00
David Ashpole
6988e70a3d Revert "fix #1708; move from inotify to fsnotify"
This reverts commit e6b6a1ac57.
2017-11-17 10:28:28 -08:00
David Ashpole
888a529088 fix #1743; move off of docker/engine-api 2017-09-28 11:05:13 -07:00
David Ashpole
e6b6a1ac57 fix #1708; move from inotify to fsnotify 2017-09-28 10:57:49 -07:00
Euan Kemp
95f9c8c86f oomparser: update to use kmsg based parser
This provides much more robust support for kernel logs via accessing the
`/dev/kmsg` interface to them directly.
2017-08-30 15:35:40 -07:00
Michael Taufen
3190c1c53d Fix journalctl leak
This fixes the journalctl leak that occurs when a process that uses
cadvisor exits. See issues #1725 and
https://github.com/kubernetes/kubernetes/issues/34965.
2017-08-23 09:14:54 -07:00
Euan Kemp
fe722c7b02 oomparser: don't get stuck for certain processes
The oomparser logic would end up stuck, unable to detect the end of a
given oom trace, for any process with a name that didn't match \w+.

This includes processes like 'python3.4' due to the '.', or
'docker-containerd' due to the '-'.

This fix was included in pr #1544 last year, but since that PR seems
dead it seems like a good idea to break this more important fix out.

I've updated the tests such that they would have caught this issue.
2017-08-01 16:21:31 -07:00
Brian Akins
feecd47daa Add watcher for zfs similar to devicemapper
minor cleanup

ensure we look at parent dataset for limit, etc
2017-03-15 18:31:11 -04:00
NickrenREN
a248c34528 optimize NewRealSysFs()
remove second return value since it will never return err
2017-03-15 12:11:50 +08:00
Andy Xie
2c1d001857 add error log for open log file 2017-01-06 10:52:03 +08:00
Random-Liu
3c3f070720 Fix bug in tail. 2016-11-10 11:39:22 -08:00
Euan Kemp
125d026aae oomparser: Fix tests
They had reflect.Equal instead of !reflect.Equal.
They also depended on the current year. Which changed.
2016-10-20 10:50:14 -07:00
Tim St. Clair
afe67fec68
Cleanup comment style: // should be proceded by a space 2016-10-07 17:06:02 -07:00
Tim St. Clair
e7576e5790
Moved google.golang.org/cloud/compute/metadata to cloud.google.com/go/compute/metadata 2016-09-13 13:59:03 -07:00
Erez Freiberger
cf548f1b70 cloudinfo: identify gce from file 2016-07-01 11:43:09 +03:00
Seth Jennings
f3bca888f8 fallback to /dev/mapper device if metadata device is not set in docker info 2016-06-21 16:01:18 -05:00
Tim St. Clair
fb5fb832ed Merge pull request #1292 from timstclair/tail
Fixes for log tailing
2016-05-19 12:16:24 -07:00
Tim St. Clair
2f0af7bb40 Fixes for log tailing
IN_ATTRIB inotify events are generated when atime / mtime is changed,
which would cause the tail to be reset, and reread the same log
again (generating duplicate events). Instead, watch the directory for
file delete / move.

Also, use an exponential backoff when retrying opening the file.
2016-05-18 18:53:35 -07:00
Tim St. Clair
18e56007c1 Merge pull request #1290 from timstclair/tail
Cleanup tail util from #1264
2016-05-18 14:46:50 -07:00
Tim St. Clair
ee24f28f73 Cleanup tail util from #1264 2016-05-18 14:36:12 -07:00
Tim St. Clair
381f24b4f2 Merge pull request #1264 from sjenning/log-rotate-support
add log file tailing and logrotate support
2016-05-18 14:35:54 -07:00
Tim St. Clair
b5d86a7288 Merge pull request #1188 from krallin/dedicated-netlink-connection-master
Use a dedicated CpuLoadReader per container
2016-05-18 13:57:37 -07:00
Tim St. Clair
3fbe18de9a Merge pull request #1204 from pmorie/dm-support
devicemapper thin_ls support
2016-05-18 12:30:05 -07:00
Paul Morie
647224c95a Add devicemapper support for docker containers 2016-05-18 15:19:20 -04:00
Thomas Orozco
2e1f0e2a08 Use a dedicated CpuLoadReader per container
This ensures each goroutine is given its own Netlink connection, and
presumably avoids having a message destined for one goroutine read by
another goroutine.
2016-05-18 09:34:13 +02:00
Seth Jennings
4790ea203b add log file tailing and logrotate support 2016-05-17 23:12:52 -05:00
Tim St. Clair
4381a51c9b Merge pull request #1242 from timstclair/timed-store
Optimize TimedStore to avoid sort on every data add
2016-05-17 13:21:03 -07:00
Tim St. Clair
2fb6849495 Merge pull request #1254 from sjenning/fix-oom-event-firing
fix chan recieve block on oom event
2016-05-17 13:11:47 -07:00
Tim St. Clair
8ccd22d2e2 Merge pull request #1171 from enoodle/aws_cloudinfo_to_read_from_dmi_file
cloudinfo: bugfix openstack identified as aws
2016-05-06 16:04:31 -07:00
Tim St. Clair
4d3ef349fb Move utils/machine -> machine 2016-05-02 15:56:49 -07:00
Seth Jennings
7fd7f20717 fix chan recieve block on oom event 2016-05-02 15:31:28 -05:00
Tim St. Clair
0c89fd1b71 Refactor docker-specific functions from manager to docker 2016-05-02 12:24:31 -07:00
Tim St. Clair
b983d32d96 Refactor manager/machine.go -> utils/machine/info.go 2016-05-02 11:54:10 -07:00
Seth Jennings
5fa60e5019 prefer using systemd for oom monitoring 2016-05-02 13:41:12 -05:00
Tim St. Clair
0973c854d6 Optimize TimedStore to avoid sort on every data add 2016-04-25 16:09:42 -07:00
Dennis Gilmore
fcf54310cd ClockSpeed not defined in /proc/cpuinfo for 32 bit arm, so return 0.
Signed-off-by: Dennis Gilmore <dennis@ausil.us>
2016-04-21 15:27:53 -05:00
Thomas Orozco
ee8701aa97 Netlink: aggressively close cgroup fds
Not closing the FDs manually means we have to rely on garbage collection
to run before cgroup FDs are closed. If the system is running a lot of
load probes at a high-frequency (i.e. dynamic housekeeping isn't backing
off because of load variations), we can end up hitting our FD limit due
to keeping around lots of (useless) FDs.
2016-04-13 11:30:48 +02:00
Erez Freiberger
b52cf9f5db cloudinfo: bugfix openstack identified as aws
Because openstack and aws uses the exact same api,
the previous method to check for if running on aws
would have returned true on openstack as well.
2016-03-20 14:52:21 +02:00
derekwaynecarr
4886fb51b2 Fix detection of AWS cloud taking 20s when not on AWS 2016-03-09 16:26:44 -05:00
derekwaynecarr
89676792bd Fix typo in constant 2016-03-08 13:00:16 -05:00
Erez Freiberger
885649a9b6 cloudinfo: Adding AWS support and InstanceID 2016-02-18 15:28:20 +02:00
Tim St. Clair
f5bceae3a2 Merge pull request #1033 from asteris-llc/master
Add the support for kafka in cAdvisor's storage, including output of container id and labels
2016-01-29 17:17:06 -05:00
Allison Richardet
80ba7e7db7 Add the support for kafka in cAdvisor's storage, including output of container id and labels
Addressing PR Feedback

Addressing PR Feedback
2016-01-27 21:33:57 -06:00
Hubert Krauze
7d053578d4 Use uint64 for Memory Stats 2016-01-20 08:46:42 +01:00
Phillip Wittrock
dee3f07b0a resolves #1030 oomparser_test should get the current year for matching the time of death. 2016-01-04 10:50:08 -08:00