Commit Graph

82 Commits

Author SHA1 Message Date
Vish Kannan
195772a1bc Merge pull request #245 from vmarmol/tests
Refactor and dependency inject containerData deps
2014-09-22 10:39:55 -07:00
Victor Marmol
e759059a09 Refactor and dependency inject containerData deps 2014-09-22 10:20:54 -07:00
Victor Marmol
e22831f1bd Flatten ContainerSpec. 2014-09-19 10:14:22 -07:00
Victor Marmol
100170beca Wording changes to SubcontainerEvent comments 2014-09-18 12:56:01 -07:00
Victor Marmol
c326475ede Remove unused filter ContainerHandlers. 2014-09-18 12:52:09 -07:00
Victor Marmol
b63d61ca97 Use inotify to watch for new containers.
This reduces cAdvisor CPU usage below 1% in my CoreOS system.

We also reduce global housekeeping to every 60s as a fallback in case we
miss an event.
2014-09-18 12:52:09 -07:00
Victor Marmol
f9c45094ab Only register the Docker driver in systems using libcontainer. 2014-09-05 13:37:18 -07:00
Victor Marmol
b75dea4021 Adding --docekr_root to customize where Docker stores state.
Fixes #199
2014-08-29 14:54:40 -07:00
Vishnu Kannan
3e390e0f33 Use glog instead of 'log' library.
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
2014-08-07 18:38:58 +00:00
Victor Marmol
00f4f840ea Move from filepath -> path for Join. 2014-08-03 10:06:39 -07:00
Victor Marmol
56054e3e31 Remove SplitName().
This is possible thanks to the new libcontainer interface that allows
the use of absolute paths.
2014-08-02 11:36:10 -07:00
Victor Marmol
fe23ba6d60 Merge pull request #140 from monnand/test-libcontainer
unit test for SplitName()
2014-07-29 08:32:03 -07:00
Nan Monnand Deng
fb5074a2f1 unit test for SplitName() 2014-07-29 01:52:59 -04:00
Nan Monnand Deng
d6551d888b list processes 2014-07-29 01:20:19 -04:00
Nan Deng
afc84e85c3 use init's cgroup to get nest level 2014-07-28 18:13:54 -07:00
Victor Marmol
7a3f7b9a29 Return an empty state for old versions of Docker.
Fixes #127.
2014-07-25 08:20:55 -07:00
Victor Marmol
5812f10db0 Merge pull request #117 from rjnagal/cpumask
Handle cpumask in raw driver for unified hierarchy.
2014-07-24 11:36:01 -07:00
Rohit Jnagal
f5fde119f8 Grab a new spec.Cpu while updating masks if cpu root didn't exist.
Docker-DCO-1.1-Signed-off-by: Rohit Jnagal <jnagal@google.com> (github: rjnagal)
2014-07-24 18:23:04 +00:00
Rohit Jnagal
b120cee75c Handle cpumask in raw driver for unified hierarchy.
Docker-DCO-1.1-Signed-off-by: Rohit Jnagal <jnagal@google.com> (github: rjnagal)
2014-07-24 17:53:38 +00:00
Victor Marmol
4d1291cf93 Merge pull request #116 from rjnagal/cpumask
Fix handling of cpumask for docker driver
2014-07-24 08:46:59 -07:00
Rohit Jnagal
1fa48e8c39 Fix handling of cpumask for docker driver. Raw driver still reports all
cpus. Will fix it to read cpumask for cgroup seperately.

Docker-DCO-1.1-Signed-off-by: Rohit Jnagal <jnagal@google.com> (github: rjnagal)
2014-07-24 01:50:32 +00:00
Victor Marmol
0126cec903 Don't fail ListContainers() on missing cgroup hierarchies. 2014-07-23 17:59:57 -07:00
Vish Kannan
6213f8b0c3 Merge pull request #107 from vmarmol/full-names
Added parent prefix to all Docker container and aliases.
2014-07-23 16:05:25 -07:00
Vishnu Kannan
41d9275b51 Fixed network stats handling. The UI now reports network errors. 2014-07-23 22:24:43 +00:00
Victor Marmol
239f4bad11 Added parent prefix to all Docker containers. 2014-07-23 13:23:27 -07:00
Victor Marmol
2e9176ae64 Fix Docker container slice in systemd systems.
It should be in /system.slice/docker-*.
2014-07-23 07:46:46 -07:00
monnand
99da79b0a9 Merge pull request #104 from vmarmol/fix
Remove lmctfy driver in favor of the raw driver
2014-07-22 21:18:01 -04:00
Victor Marmol
eef8c01e4e Better handle nested containers and libcontainer. 2014-07-22 18:04:08 -07:00
Victor Marmol
07b9ed3244 Remove lmctfy driver in favor of the raw driver 2014-07-22 14:09:42 -07:00
Victor Marmol
e951d03be6 Implement GeSpec() in the simple raw driver. 2014-07-22 13:51:24 -07:00
Vishnu Kannan
a748b53743 Docker ListContainers will work only for the '/docker' container. 2014-07-22 19:55:14 +00:00
Vishnu Kannan
f147996e9d Ignore non '/docker' containers in the docker driver. 2014-07-22 19:55:14 +00:00
Vishnu Kannan
5dfa7b64ba Removed NotActive error message from container package.
Imporved error messages.
2014-07-22 19:55:14 +00:00
Vishnu Kannan
ef13440034 Addressed comments. Another series of bug fixes.
Modified the docker driver and lmctfy driver to skip containers they cannot handle.
2014-07-22 19:55:14 +00:00
Vishnu Kannan
5aae36726f Fixed bugs introduced in previous patches. 2014-07-22 18:58:16 +00:00
Vishnu Kannan
7f96c90c72 Fix raw cgroups handler. 2014-07-22 18:58:16 +00:00
Vishnu Kannan
1edb798de5 Features:
Added Network Stats to Container Info. It still not exposed via the HTTP UI.
Bug fixes:
1. Modified docker handler to use libcontainer.GetStats instead of quering the fs package.
2. cAdvisor will not stall if any of its core operations fail.
3. cAdvisor will safely ignore any inactive or leaked docker containers. When containers are leaked cgroup state exists but docker is not aware of them.
2014-07-22 18:58:16 +00:00
Victor Marmol
a187d74e5b Enable the simple raw driver.
It doesn't yet get the spec, but it is functional enough to use.
This removed the registration of lmctfy, the code will be removed in a
future PR once raw GetSpec() is complete.
2014-07-21 19:02:07 -07:00
Victor Marmol
3854ea6970 Remove cpuset cgroup for listing on raw driver.
Also a couple of fixes/simplifications.
2014-07-21 18:00:55 -07:00
Victor Marmol
4c52e2ea1c Implement ListContainers and no-op GetSpec(). 2014-07-17 14:22:37 -07:00
Victor Marmol
a8863e6367 Initial version of the raw container driver. 2014-07-17 10:45:59 -07:00
Victor Marmol
1636c3e759 Change ContainerHandlerFactories to decide what containers they support.
This allows a ContainerHandlerFactory to register a CanHandle() function
which is called to determine whether the factory can handle a particular
container.

This commit disables being able to run cAdvisor without lmctfy. This
should be enabled again with a "no-op" global factory which I would like
to do in a separate PR.
2014-07-16 16:48:45 -07:00
Victor Marmol
c4c604c278 Handle systemd when it is present. 2014-07-14 10:00:21 -07:00
Nan Deng
018d514981 mock container 2014-07-03 21:03:04 -07:00
Nan Deng
0ade2f1c23 mock container handler 2014-07-03 23:39:08 +00:00
Nan Monnand Deng
304a166d7a working set = usage - inactive 2014-06-27 14:47:02 -04:00
Nan Monnand Deng
875146e396 calculate working set based on #. pages in active LRU. 2014-06-27 13:03:05 -04:00
Victor Marmol
dcedfe3c9d Rename libcontainer.Container -> libcontainer.Config 2014-06-24 14:54:30 -07:00
Nan Deng
3718b139b3 remove StatsPercentiles in container handler 2014-06-17 12:55:51 -07:00
Nan Deng
51eabfcfa7 unit test 2014-06-16 20:49:40 -07:00