Commit Graph

2917 Commits

Author SHA1 Message Date
Maciej "Iwan" Iwanowski
bcd6c9c158
Using multistage dockerfile and upgrading alpine to 3.12
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@critical.today>
2020-06-07 00:21:29 +02:00
David Ashpole
6c8da9243e
Merge pull request #2555 from katarzyna-z/kk-k8s-with-perf
Add instruction for running cAdvisor with perf support on k8s
2020-06-05 08:48:01 -07:00
Katarzyna Kujawa
e89bae456b Remove versions of packages installed in container
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-06-05 14:01:20 +02:00
Katarzyna Kujawa
cff7e58eea Fix #2566 warning instead of error when core_id or physical_package_id not available
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-06-05 13:19:55 +02:00
Renaud Gaubert
4bc592b147 Make NVIDIA capitalization consistent in comments
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
2020-06-05 00:07:53 +00:00
Renaud Gaubert
170bae8a5d Return a NoopManager if metricset does not container the accelerator value
This is because the NVIDIA manager opens a handle on nvml at
NewNvidiaManager time.

This is problematic in a kubernetes setting where kubelet now has an
open handle on the NVIDIA driver, preventing an update of the NVIDIA
driver unless kubelet is restarted.

Additionally with the new metrics pipeline in Kubernetes, metrics are
now expected to be collected through a container rather than through the
kubelet itself.

Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
2020-06-05 00:06:48 +00:00
David Ashpole
366d59d3b6
Merge pull request #2573 from shyaamsn/update_go-systemd_v22
Update opencontainers/runc
2020-06-03 16:49:27 -07:00
Shyaam Nagarajan
8f6520c4d6 Bump dependency opencontainers/runc 2020-06-03 23:36:36 +00:00
David Ashpole
fe65b1eeb6
Merge pull request #2572 from ykakarap/master
updating go-conenctions to v0.4.0
2020-06-03 16:05:39 -07:00
Yuvaraj Kakaraparthi
6437801715 updating go-conenctions to v0.4.0 2020-06-03 14:43:23 -07:00
David Ashpole
e1a88ceea4
Merge pull request #2569 from google/dashpole-patch-1
update go version in docs to 1.14
2020-06-03 10:13:29 -07:00
David Ashpole
d0f4ad9e2d
update go version in docs to 1.14 2020-06-03 09:57:56 -07:00
Katarzyna Kujawa
87354faf0f Modify instruction for cAdvisor with perf on k8s
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-06-03 11:29:44 +02:00
Katarzyna Kujawa
81ad6bc082 Add building of cAdvisor with libpfm4 for Docker container
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-06-03 09:40:32 +02:00
David Ashpole
37422b080b
Merge pull request #2565 from iwankgb/not_collecting_root_container_disk_stats
Not collecting disk metric for root container when not requested to
2020-06-01 10:20:53 -07:00
Maciej "Iwan" Iwanowski
e3affc1b79
Not collecting disk metric for root container when not requested to 2020-05-31 00:06:06 +02:00
Katarzyna Kujawa
cd46e07489 Add libpfm4 to main Dockerfile
Remove Dockerfile for perf events

Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-29 11:02:31 +02:00
David Ashpole
8d4d5ea98d
Merge pull request #2550 from lubinszARM/pr_cache_log
Move the cache missing log from level-0 to level-1
2020-05-27 09:03:45 -07:00
David Ashpole
f71439b862
Merge pull request #2291 from mJace/numa_support
Provide PSR information for containers.
2020-05-27 09:02:30 -07:00
David Ashpole
147ca3e36c
Merge pull request #2559 from katarzyna-z/kk-fix-perf-stats-api
Fixes perf stats and hugetlb stats on API v2.0
2020-05-27 08:54:59 -07:00
Katarzyna Kujawa
9ccd156d50 Fixes hugetlb stats on API v2.0
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-27 14:05:31 +02:00
Katarzyna Kujawa
f64578421e Fixes perf stats on API v2.0
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-27 11:50:14 +02:00
mjace
52f9cd97ce Add psr option when ps containers 2020-05-27 15:01:54 +08:00
David Ashpole
107e5aa4c3
Merge pull request #2558 from AlexeyPerevalov/socket_id
Fix test with different order of Topology's nodes
2020-05-26 15:26:18 -07:00
David Ashpole
92f31e79a7
Merge pull request #2556 from gaurav1086/oomparser_fix_data_race
oomparser_test: fix data race
2020-05-26 13:33:52 -07:00
Alexey Perevalov
2e2a4c496a Fix test with different order of Topology's nodes
GetTopology provides Nodes not in order of Node.Id.
PR https://github.com/google/cadvisor/pull/2551 removed that check,
as result test acidentially passed.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
2020-05-26 21:32:12 +03:00
Gaurav Singh
7df66d30ec Fix build errors
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-26 14:03:57 -04:00
David Ashpole
12c678119a
Merge pull request #2554 from katarzyna-z/kk-running-docs
Information about running cAdvisor without privileged option
2020-05-26 09:51:15 -07:00
David Ashpole
7de12532ec
Merge pull request #2553 from dashpole/docs_update
Add /dev/kmsg to docker example
2020-05-26 09:49:50 -07:00
David Ashpole
c481d7c60c
Merge pull request #2551 from AlexeyPerevalov/socket_id
Add socket id into Core
2020-05-26 09:48:42 -07:00
Gaurav Singh
83f722be88 oomparser_test: fix data race
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-23 00:11:00 -04:00
Katarzyna Kujawa
a640488bcc Information about running cAdvisor without privileged option
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-22 09:13:17 +02:00
David Ashpole
bfa1f90800 add /dev/kmsg to docker example 2020-05-21 15:58:05 -07:00
David Ashpole
425e2117eb
Merge pull request #2552 from tedyu/subcont-nil-chk
Check container against nil before de-referencing
2020-05-21 15:37:58 -07:00
Ted Yu
1ae6987854 Check container against nil before de-referencing
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-21 15:28:59 -07:00
David Ashpole
9253ce057a
Merge pull request #2469 from giuseppe/update-libcontainer
libcontainer, cgroupv2: adapt to new API
2020-05-21 15:05:41 -07:00
David Ashpole
0c14aab88e
Merge pull request #2540 from ctripcloud/addWarnLogForMissingContainerInfo
fix missing container info when getting sub-containers stats
2020-05-21 09:54:08 -07:00
David Ashpole
43a9bd9d93
Merge pull request #2543 from kshithijiyer/patch-1
Reformat README
2020-05-21 09:52:58 -07:00
Alexey Perevalov
a5e4d35ad3 Add socket id into Core
Now cadvisor in MachineInfo.Topology keeps NUMA nodes.
There is no socket information, except number of sockets.
Since socket - NUMA nodes relationship could be many-to-many,
it's more reasonable to keep socket_id per Core, not per NUMA node.

This socket id could be used in kubernetes cpu manager to provide
per socket allocations.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
2020-05-21 18:07:13 +03:00
Bin Lu
81428da093 Move the cache missing log from level-0 to level-1
Signed-off-by: Bin Lu <bin.lu@arm.com>
2020-05-21 01:10:39 -04:00
David Ashpole
64ac14e2ef
Merge pull request #2549 from gaurav1086/runner_fix_goroutine_leak
runner: fix goroutine leak
2020-05-20 10:18:03 -07:00
Giuseppe Scrivano
ab2da09c28
libcontainer: use inactive_file on cgroup v2
total_inactive_file is present only on cgroup v1

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-05-20 16:07:17 +02:00
Giuseppe Scrivano
6a95c22c20
libcontainer, cgroupv2: adapt to new API
adapt the handlers to use the new libcontainer API for cgroup v2.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-05-20 16:07:16 +02:00
Katarzyna Kujawa
df60562b39 Add instruction for running cAdvisor with perf support on k8s
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
2020-05-20 12:17:20 +02:00
ChenQingya
522e8bcaf5 fix SubcontainersInfo response not recursive bug
Signed-off-by: ChenQingya <qingya.chen520@gmail.com>
2020-05-20 17:19:24 +08:00
Gaurav Singh
4819f60acf runner: fix goroutine leak
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-19 21:44:15 -04:00
David Ashpole
f28cda1a21
Merge pull request #2547 from dashpole/integration_flake
Lengthen timeout and add additional information for debugging flakes
2020-05-18 12:44:56 -07:00
David Ashpole
241260f47d lengthen timeout and add additional information for debugging flakes 2020-05-18 12:24:13 -07:00
David Ashpole
3f032baf42
Merge pull request #2546 from google/dashpole-patch-1
update canary job to go 1.14
2020-05-18 10:39:13 -07:00
David Ashpole
40c154a479
update canary job to go 1.14 2020-05-18 10:20:55 -07:00