Commit Graph

2971 Commits

Author SHA1 Message Date
David Ashpole
1298173196
Merge pull request #2494 from iwankgb/perf_in_prometheus
Exposing perf metrics in Prometheus
2020-04-17 08:31:27 -07:00
Maciej "Iwan" Iwanowski
14bab95da5
Bringing the docs up-to-date
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-17 09:56:12 +02:00
Maciej "Iwan" Iwanowski
39ae19d514
Bringing function and regexp names back to original
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-17 09:03:13 +02:00
Maciej "Iwan" Iwanowski
18902209dc
Getting rid of old version of klog (and some other dependiencies fixed)
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-17 08:55:00 +02:00
Maciej "Iwan" Iwanowski
d153066bb0
Using constant names for metrics, as Prometheus encourages to
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-17 08:51:03 +02:00
Maciej "Iwan" Iwanowski
bf1f3ccbda
Sanitizing perf metrics names and documenting newly added metrics
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-16 11:00:35 +02:00
Maciej "Iwan" Iwanowski
95460a3ca6
Fixing silly formatting issue
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-16 08:41:23 +02:00
Maciej "Iwan" Iwanowski
f4fec880e7
Exposing perf metrics in Prometheus
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-16 08:41:01 +02:00
David Ashpole
ba6fa06c73
Merge pull request #2489 from iwankgb/perf_integration_tests
Integration test for Docker and perf stats
2020-04-15 09:59:27 -07:00
Maciej "Iwan" Iwanowski
4a2441a46a
New line at the end of file
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 11:18:09 +02:00
Maciej "Iwan" Iwanowski
96150b3fb7
No environment configuration for unit tests
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 11:17:11 +02:00
Maciej "Iwan" Iwanowski
5cfb4c2325
Extending integration tests documentation
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 10:51:38 +02:00
Maciej "Iwan" Iwanowski
396c32a3b6
We no longer need to append entries to logfile
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 08:45:31 +02:00
Maciej "Iwan" Iwanowski
d991727c10
Adding build config to unit tests too
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 08:45:31 +02:00
Maciej "Iwan" Iwanowski
456582c5ac
Adding missing boilerplate comments
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 08:45:31 +02:00
Maciej "Iwan" Iwanowski
5a0d353c0b
Using environment variables to create build matrix
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 08:45:31 +02:00
Maciej "Iwan" Iwanowski
9945e3572a
Fixed typo
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 08:45:31 +02:00
Maciej "Iwan" Iwanowski
764622ff45
Integration test for Docker and perf stats
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-15 08:45:30 +02:00
David Ashpole
713e6af0d1
Merge pull request #2492 from tedyu/container-info-copy
Make a copy of containerInfo in containerData#GetInfo
2020-04-14 11:24:01 -07:00
Ted Yu
cbfa6e8b19 Make a copy of containerInfo in containerData#GetInfo
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-13 13:42:49 -07:00
David Ashpole
b52edf25b3
Merge pull request #2491 from tedyu/mach-info-map
Make a copy of the maps of MachineInfo
2020-04-13 09:35:01 -07:00
Ted Yu
7cf9bf1b60 Make a copy of the maps of MachineInfo
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-11 17:37:31 -07:00
David Ashpole
3b7947f333
Merge pull request #2490 from tedyu/mach-info-copy
Make a copy of MachineInfo in GetMachineInfo()
2020-04-10 11:01:42 -07:00
Ted Yu
cf1ac06b2c Make a copy of MachineInfo in GetMachineInfo()
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-10 10:07:38 -07:00
David Ashpole
ca7a1173b7
Merge pull request #2478 from dims/switch-to-klog-v2
Switch to klog v2
2020-04-10 09:13:38 -07:00
David Ashpole
f72e6ae382
Merge pull request #2448 from dims/docker-based-integration-test
Docker based integration test for cadvisor
2020-04-10 09:04:21 -07:00
Davanum Srinivas
94508e8a2f
Switch to klog v2
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-09 22:54:37 -04:00
David Ashpole
49f4075210
Merge pull request #2486 from tedyu/cont-stat-eq
Add missing fields to ContainerStats#StatsEq
2020-04-09 15:44:13 -07:00
Ted Yu
4824925f07 Add missing fields to ContainerStats#StatsEq
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-09 15:24:32 -07:00
David Ashpole
84ef5301ee
Merge pull request #2480 from tedyu/cont-spec-eq
Add missing fields to ContainerSpec#Eq
2020-04-09 11:38:20 -07:00
Ted Yu
f7b3d111c3 Add missing fields to ContainerSpec#Eq
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-09 10:39:41 -07:00
iwankgb
e7efc0a49d
Measuring perf events - chapter I (#2419)
* Configuration and initial implementation of perf events.

Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-09 10:20:07 -07:00
iwankgb
1baad3f20b
Returning more error information from stats.Manager and stats.Collector (#2477)
* Returning more error information from stats.Manager and stats.Collector

Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-09 09:42:02 -07:00
David Ashpole
9de631424e
Merge pull request #2479 from tedyu/mgr-exists
manager#Exists should take read lock
2020-04-09 09:35:20 -07:00
David Ashpole
e35a0d574a
Merge pull request #2456 from lubinszARM/pr_cacheinfo
Issue fix: get wrong machine info on Arm64 guest
2020-04-09 09:03:52 -07:00
bblu
7f1ea45122 Issue fix: get wrong machine info in Arm64 guest
The latest kubernetes deployment on Arm64 VM-s always fails.
Because k8s always get num_cores=0 from cAdvisor on Arm64 VM-s.

The reason is that, there is no cache info on Arm64 VM-s.
And the good news is that, we can get cache info on Arm64 hosts.

When this patch was merged, I will deliver a patch to update the version
of cAdvisor in kubernetes as soon as possible.

Signed-off-by: bblu <bin.lu@arm.com>
2020-04-09 14:01:45 +08:00
Ted Yu
b2891b7e9b manager#Exists should take read lock
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-08 19:17:07 -07:00
David Ashpole
ebfe3ce776
Merge pull request #2475 from giuseppe/fix-assets
cmd: fix path for assets
2020-04-08 10:19:35 -07:00
David Ashpole
12190a2d2a
Merge pull request #2476 from iwankgb/using_value_before_checking_for_error
Returning error before using value
2020-04-08 09:58:46 -07:00
Maciej "Iwan" Iwanowski
3342050493
Returning error before using value
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@intel.com>
2020-04-08 17:04:36 +02:00
Giuseppe Scrivano
a319876023
cmd: fix path for assets
commit c22edbcc7d moved the files under
cmd/internal.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-08 09:26:22 +02:00
David Ashpole
7f840ac879
Merge pull request #2331 from saschagrunert/crio-drivers
Update CRI-O storage driver support
2020-04-07 09:26:35 -07:00
David Ashpole
f41d71fa3f
Merge pull request #2474 from tedyu/cpu-package-id
Check the error return from GetCPUPhysicalPackageID()
2020-04-07 09:24:19 -07:00
Davanum Srinivas
831b5000c2
fix test to ensure nodes are sorted
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-06 20:30:24 -04:00
Davanum Srinivas
c37b1cb9dc
Use github actions to run tests
Runs against go 1.13 adn 1.14 using ubuntu latest

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-06 20:00:04 -04:00
Davanum Srinivas
315d155a9d
Add a docker based integration test
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-06 19:57:28 -04:00
Davanum Srinivas
9303744bfe
Pick the right Network interface
On Docker / macOS, there is a tun10 and a eth0, so we pick the right one
to check for traffic to avoid flakes

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-06 19:57:09 -04:00
Ted Yu
f6e5433e67 Check the error return from GetCPUPhysicalPackageID()
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-06 16:50:53 -07:00
Davanum Srinivas
74bd4f1516
Support for vfs driver
Gives us the ability to run tests on Docker macOS

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-06 19:50:04 -04:00
David Ashpole
069f7e7eb6
Merge pull request #2471 from katarzyna-z/kk-fix-cpus-without-nodes
Fix getting CPU topology
2020-04-06 16:24:10 -07:00