diff --git a/container/docker/factory.go b/container/docker/factory.go index 7e7c548e..8e6a6d93 100644 --- a/container/docker/factory.go +++ b/container/docker/factory.go @@ -27,12 +27,12 @@ import ( "github.com/blang/semver" dockertypes "github.com/docker/docker/api/types" "github.com/google/cadvisor/container" + dockerutil "github.com/google/cadvisor/container/docker/utils" "github.com/google/cadvisor/container/libcontainer" "github.com/google/cadvisor/devicemapper" "github.com/google/cadvisor/fs" info "github.com/google/cadvisor/info/v1" "github.com/google/cadvisor/machine" - dockerutil "github.com/google/cadvisor/utils/docker" "github.com/google/cadvisor/watcher" "github.com/google/cadvisor/zfs" diff --git a/container/docker/handler.go b/container/docker/handler.go index ae8f48ef..ff1cbffa 100644 --- a/container/docker/handler.go +++ b/container/docker/handler.go @@ -25,11 +25,11 @@ import ( "github.com/google/cadvisor/container" "github.com/google/cadvisor/container/common" + dockerutil "github.com/google/cadvisor/container/docker/utils" containerlibcontainer "github.com/google/cadvisor/container/libcontainer" "github.com/google/cadvisor/devicemapper" "github.com/google/cadvisor/fs" info "github.com/google/cadvisor/info/v1" - dockerutil "github.com/google/cadvisor/utils/docker" "github.com/google/cadvisor/zfs" dockercontainer "github.com/docker/docker/api/types/container" diff --git a/utils/docker/docker.go b/container/docker/utils/docker.go similarity index 99% rename from utils/docker/docker.go rename to container/docker/utils/docker.go index e19097d6..a837460e 100644 --- a/utils/docker/docker.go +++ b/container/docker/utils/docker.go @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package docker +package utils import ( "fmt" diff --git a/fs/fs.go b/fs/fs.go index ae77d87b..ff534291 100644 --- a/fs/fs.go +++ b/fs/fs.go @@ -32,7 +32,6 @@ import ( "github.com/google/cadvisor/devicemapper" "github.com/google/cadvisor/utils" - dockerutil "github.com/google/cadvisor/utils/docker" zfs "github.com/mistifyio/go-zfs" "k8s.io/klog" @@ -40,9 +39,11 @@ import ( ) const ( - LabelSystemRoot = "root" - LabelDockerImages = "docker-images" - LabelCrioImages = "crio-images" + LabelSystemRoot = "root" + LabelDockerImages = "docker-images" + LabelCrioImages = "crio-images" + DriverStatusPoolName = "Pool Name" + DriverStatusDataLoopFile = "Data loop file" ) const ( @@ -236,7 +237,7 @@ func (self *RealFsInfo) getDockerDeviceMapperInfo(context DockerContext) (string return "", nil, nil } - dataLoopFile := context.DriverStatus[dockerutil.DriverStatusDataLoopFile] + dataLoopFile := context.DriverStatus[DriverStatusDataLoopFile] if len(dataLoopFile) > 0 { return "", nil, nil } @@ -632,7 +633,7 @@ func getVfsStats(path string) (total uint64, free uint64, avail uint64, inodes u // Devicemapper thin provisioning is detailed at // https://www.kernel.org/doc/Documentation/device-mapper/thin-provisioning.txt func dockerDMDevice(driverStatus map[string]string, dmsetup devicemapper.DmsetupClient) (string, uint, uint, uint, error) { - poolName, ok := driverStatus[dockerutil.DriverStatusPoolName] + poolName, ok := driverStatus[DriverStatusPoolName] if !ok || len(poolName) == 0 { return "", 0, 0, 0, fmt.Errorf("Could not get dm pool name") }