prometheus/cadvisor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Only retry whitelisted test failure flakes instead of retrying on any failure.

Browse Source 
We should explicitly be retrying on certain conditions and not blindly doing so.
This commit is contained in:
Phillip Wittrock 2016-01-04 14:42:44 -08:00
parent 38cf3a0972
commit e2b96bb877
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
integration/runner/runner.go
View File

@ -23,6 +23,7 @@ import (
"os" "os"
"os/exec" "os/exec"
"path" "path"
"regexp"
"strconv" "strconv"
"strings" "strings"
"sync" "sync"
@ -117,6 +118,9 @@ func PushAndRunTests(host, testDir string) error {
// Run the tests in a retry loop. // Run the tests in a retry loop.
glog.Infof("Running integration tests targeting %q...", host) glog.Infof("Running integration tests targeting %q...", host)
// Only retry on test failures caused by these known flaky failure conditions
retryRegex := regexp.MustCompile("Network tx and rx bytes should not be equal")
for i := 0; i <= *testRetryCount; i++ { for i := 0; i <= *testRetryCount; i++ {
// Check if this is a retry // Check if this is a retry
if i > 0 { if i > 0 {
@ -129,6 +133,10 @@ func PushAndRunTests(host, testDir string) error {
// On success, break out of retry loop // On success, break out of retry loop
break break
} }
if !retryRegex.Match([]byte(err.Error())) {
// If error not in whitelist, break out of loop
break
}
} }
if err != nil { if err != nil {
err = fmt.Errorf("error on host %s: %v", host, err) err = fmt.Errorf("error on host %s: %v", host, err)