prometheus/cadvisor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove page faults from cadvisor UI.

Browse Source 
Page fault data is useful for inference and performance detection, but
it doesn't make sense on the summary UI. We have limited space on the
main container page. Let's use it for main throughput signals. Removing
faults make network stats more prominent too.

Docker-DCO-1.1-Signed-off-by: Rohit Jnagal <jnagal@google.com> (github: rjnagal)
This commit is contained in:
Rohit Jnagal 2014-08-22 16:53:37 +00:00
parent 42c0943d7e
commit ac72c056c3
2 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pages/containers_html.go
View File

@ -144,8 +144,6 @@ const containersHtmlTemplate = `
{{ getMemoryUsage .Stats }} MB ({{ getMemoryUsagePercent .Spec .Stats .MachineInfo}}%)
</div>
</div>
<h4>Page Faults</h4>
<div id="memory-page-faults-chart"></div>
</div>
</div>
{{end}}

22
pages/static/containers_js.go
View File

@ -205,25 +205,6 @@ function drawMemoryUsage(elementId, containerInfo) {
drawLineChart(titles, data, elementId, "Megabytes");
}
function drawMemoryPageFaults(elementId, containerInfo) {
var titles = ["Time", "Faults", "Major Faults"];
var data = [];
for (var i = 1; i < containerInfo.stats.length; i++) {
var cur = containerInfo.stats[i];
var prev = containerInfo.stats[i - 1];
// TODO(vmarmol): This assumes we sample every second, use the timestamps.
var elements = [];
elements.push(cur.timestamp);
elements.push(cur.memory.hierarchical_data.pgfault - prev.memory.hierarchical_data.pgfault);
// TODO(vmarmol): Fix to expose this data.
//elements.push(cur.memory.hierarchical_data.pgmajfault - prev.memory.hierarchical_data.pgmajfault);
elements.push(0);
data.push(elements);
}
drawLineChart(titles, data, elementId, "Faults");
}
// Draw the graph for network tx/rx bytes.
function drawNetworkBytes(elementId, machineInfo, stats) {
var titles = ["Time", "Tx bytes", "Rx bytes"];
@ -301,9 +282,6 @@ function drawCharts(machineInfo, containerInfo) {
steps.push(function() {
drawMemoryUsage("memory-usage-chart", containerInfo);
});
steps.push(function() {
drawMemoryPageFaults("memory-page-faults-chart", containerInfo);
});
// Network.
steps.push(function() {