prometheus/cadvisor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Checks environment variables for empty strings

Browse Source 
If an environment variable is an empty string, cadvisor panics and fails to start
This commit is contained in:
Calum Lacroix 2017-02-08 18:44:56 +00:00 committed by GitHub
parent 36ab9f9aa4
commit 967e09a3a5
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
container/docker/handler.go
View File

@ -252,9 +252,11 @@ func newDockerContainerHandler(
// split env vars to get metadata map. // split env vars to get metadata map.
for _, exposedEnv := range metadataEnvs { for _, exposedEnv := range metadataEnvs {
for _, envVar := range ctnr.Config.Env { for _, envVar := range ctnr.Config.Env {
splits := strings.SplitN(envVar, "=", 2) if envVar != "" {
if splits[0] == exposedEnv { splits := strings.SplitN(envVar, "=", 2)
handler.envs[strings.ToLower(exposedEnv)] = splits[1] if splits[0] == exposedEnv {
handler.envs[strings.ToLower(exposedEnv)] = splits[1]
}
} }
} }
} }