From 76cb710e13807a4528874c76cb315b6e08e2c5c5 Mon Sep 17 00:00:00 2001
From: Rohit Jnagal <jnagal@google.com>
Date: Fri, 22 Aug 2014 16:53:37 +0000
Subject: [PATCH] Remove page faults from cadvisor UI. Page fault data is
 useful for inference and performance detection, but it doesn't make sense on
 the summary UI. We have limited space on the main container page. Let's use
 it for main throughput signals. Removing faults make network stats more
 prominent too.

Docker-DCO-1.1-Signed-off-by: Rohit Jnagal <jnagal@google.com> (github: rjnagal)
---
 pages/containers_html.go      |  2 --
 pages/static/containers_js.go | 22 ----------------------
 2 files changed, 24 deletions(-)

diff --git a/pages/containers_html.go b/pages/containers_html.go
index 5d311b7d..e789dc47 100644
--- a/pages/containers_html.go
+++ b/pages/containers_html.go
@@ -144,8 +144,6 @@ const containersHtmlTemplate = `
 		{{ getMemoryUsage .Stats }} MB ({{ getMemoryUsagePercent .Spec .Stats .MachineInfo}}%)
               </div>
 	    </div>
-            <h4>Page Faults</h4>
-	    <div id="memory-page-faults-chart"></div>
           </div>
 	</div>
 	{{end}}
diff --git a/pages/static/containers_js.go b/pages/static/containers_js.go
index 0858d5e1..0a550295 100644
--- a/pages/static/containers_js.go
+++ b/pages/static/containers_js.go
@@ -205,25 +205,6 @@ function drawMemoryUsage(elementId, containerInfo) {
 	drawLineChart(titles, data, elementId, "Megabytes");
 }
 
-function drawMemoryPageFaults(elementId, containerInfo) {
-	var titles = ["Time", "Faults", "Major Faults"];
-	var data = [];
-	for (var i = 1; i < containerInfo.stats.length; i++) {
-		var cur = containerInfo.stats[i];
-		var prev = containerInfo.stats[i - 1];
-
-		// TODO(vmarmol): This assumes we sample every second, use the timestamps.
-		var elements = [];
-		elements.push(cur.timestamp);
-		elements.push(cur.memory.hierarchical_data.pgfault - prev.memory.hierarchical_data.pgfault);
-		// TODO(vmarmol): Fix to expose this data.
-		//elements.push(cur.memory.hierarchical_data.pgmajfault - prev.memory.hierarchical_data.pgmajfault);
-		elements.push(0);
-		data.push(elements);
-	}
-	drawLineChart(titles, data, elementId, "Faults");
-}
-
 // Draw the graph for network tx/rx bytes.
 function drawNetworkBytes(elementId, machineInfo, stats) {
 	var titles = ["Time", "Tx bytes", "Rx bytes"];
@@ -301,9 +282,6 @@ function drawCharts(machineInfo, containerInfo) {
 	steps.push(function() {
 		drawMemoryUsage("memory-usage-chart", containerInfo);
 	});
-	steps.push(function() {
-		drawMemoryPageFaults("memory-page-faults-chart", containerInfo);
-	});
 
 	// Network.
 	steps.push(function() {