diff --git a/storage/storage.go b/storage/storage.go index 51f0b9c0..cd6af4c8 100644 --- a/storage/storage.go +++ b/storage/storage.go @@ -19,9 +19,11 @@ import "github.com/google/cadvisor/info" type StorageDriver interface { AddStats(ref info.ContainerReference, stats *info.ContainerStats) error - // Read most recent stats. numStats indicates max number of stats - // returned. The returned stats must be consecutive observed stats. If - // numStats < 0, then return all stats stored in the storage. + // Read most recent stats. The returned stats must be reverse + // chronological ordered. i.e. most recent comes first. numStats + // indicates max number of stats returned. The returned stats must be + // consecutive observed stats. If numStats < 0, then return all stats + // stored in the storage. RecentStats(containerName string, numStats int) ([]*info.ContainerStats, error) // Read the specified percentiles of CPU and memory usage of the container. diff --git a/storage/test/storagetests.go b/storage/test/storagetests.go index 1b23fd24..0476791e 100644 --- a/storage/test/storagetests.go +++ b/storage/test/storagetests.go @@ -254,7 +254,6 @@ func StorageDriverTestRetrievePartialRecentStats(driver storage.StorageDriver, t } } -// The driver must be albe to hold more than 10 stats func StorageDriverTestRetrieveAllRecentStats(driver storage.StorageDriver, t *testing.T) { defer driver.Close() N := 100