Merge pull request #417 from vmarmol/gofmt

Add Gofmt Check

.travis.yml

@@ -11,6 +11,7 @@ before_script:
  - sudo service influxdb start
 script:
  - export PATH=$PATH:$HOME/gopath/bin
+ - ./deploy/check_gofmt.sh .
+ - go vet github.com/google/cadvisor/...
  - godep go test -v -race -test.short github.com/google/cadvisor/...
  - godep go build github.com/google/cadvisor
- - go vet github.com/google/cadvisor/...

client/client_test.go

@@ -79,7 +79,7 @@ func TestGetMachineinfo(t *testing.T) {
 		NumCores:       8,
 		MemoryCapacity: 31625871360,
 		DiskMap: map[string]info.DiskInfo{
-			"8:0": info.DiskInfo{
+			"8:0": {
 				Name:  "sda",
 				Major: 8,
 				Minor: 0,

container/docker/handler.go

@@ -159,7 +159,7 @@ func (self *dockerContainerHandler) readLibcontainerConfig() (*libcontainer.Conf
 
 		// Translate the old config into the new config.
 		config = oldConfig.Config
-		for ns, _ := range oldConfig.OldNamespaces {
+		for ns := range oldConfig.OldNamespaces {
 			config.Namespaces = append(config.Namespaces, libcontainer.Namespace{
 				Name: ns,
 			})

deploy/check_gofmt.sh

@@ -0,0 +1,19 @@
+#!/bin/bash
+
+# Check usage.
+if [ $# -ne 1 ]; then
+  echo "USAGE: check_gofmt <source directory>"
+  exit 1
+fi
+
+# Check formatting on non Godep'd code.
+GOFMT_PATHS=$(find . -not -wholename "*.git*" -not -wholename "*Godeps*" -not -name "." -type d)
+
+# Find any files with gofmt problems
+BAD_FILES=$(gofmt -s -l $GOFMT_PATHS)
+
+if [ -n "$BAD_FILES" ]; then
+  echo "The following files are not properly formatted:"
+  echo $BAD_FILES
+  exit 1
+fi

info/machine.go

@@ -76,7 +76,7 @@ func (self *Node) AddNodeCache(c Cache) {
 }
 
 func (self *Node) AddPerCoreCache(c Cache) {
-	for idx, _ := range self.Cores {
+	for idx := range self.Cores {
 		self.Cores[idx].Caches = append(self.Cores[idx].Caches, c)
 	}
 }

pages/docker.go

@@ -43,7 +43,7 @@ func serveDockerPage(m manager.Manager, w http.ResponseWriter, u *url.URL) error
 		data = &pageData{
 			DisplayName: dockerContainersText,
 			ParentContainers: []link{
-				link{
+				{
 					Text: dockerContainersText,
 					Link: DockerPage,
 				}},

pages/static/google_jsapi_js.go

@@ -14,7 +14,7 @@
 
 package static
 
-const googleJsapiJs= `
+const googleJsapiJs = `
 if(!window['googleLT_']){window['googleLT_']=(new Date()).getTime();}if (!window['google']) {
 window['google'] = {};
 }

storage/memory/stats_buffer_test.go

@@ -4,7 +4,6 @@ import (
 	"testing"
 
 	"github.com/google/cadvisor/info"
-
 )
 
 func createStats(id int32) *info.ContainerStats {