From 5b68fc281ae656339433a3fe4e81b56aa3e8f132 Mon Sep 17 00:00:00 2001 From: Jason Swindle Date: Tue, 10 Jun 2014 15:49:35 -0500 Subject: [PATCH 1/3] Use full flags and... move to the background. Having it in the foreground that you cannot easily exit out of is jarring. I am more than happy to remove the background flags, but I feel it is a better user user experience this way. --- README.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index fe4fdb8f..d55f7257 100644 --- a/README.md +++ b/README.md @@ -12,14 +12,17 @@ To quickly tryout cAdvisor on your machine with Docker (version 0.11 or above), ``` sudo docker run \ - -v /var/run:/var/run:rw \ - -v /sys/fs/cgroup/:/sys/fs/cgroup:ro \ - -v /var/lib/docker/:/var/lib/docker:ro \ - -p 0.0.0.0:8080:8080 \ + --interactive=true \ + --tty=true \ + --volume=/var/run:/var/run:rw \ + --volume=/sys/fs/cgroup/:/sys/fs/cgroup:ro \ + --volume=/var/lib/docker/:/var/lib/docker:ro \ + --publish=8080:8080 \ + --detach=true \ google/cadvisor ``` -cAdvisor is now running (in the foreground) on `http://localhost:8080`. The setup includes directories with Docker state cAdvisor needs to observe. +cAdvisor is now running (in the background) on `http://localhost:8080`. The setup includes directories with Docker state cAdvisor needs to observe. If you want to build your own cAdvisor Docker image, take a look at the Dockerfile which can build a cAdvisor docker container under `quickstart/Dockerfile`. From eaa9c0c185271b7ca472eb842b3f53a4dcba806d Mon Sep 17 00:00:00 2001 From: Jason Swindle Date: Tue, 10 Jun 2014 15:59:59 -0500 Subject: [PATCH 2/3] changing interactive to false vs true... --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d55f7257..d7272506 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ To quickly tryout cAdvisor on your machine with Docker (version 0.11 or above), ``` sudo docker run \ - --interactive=true \ + --interactive=false \ --tty=true \ --volume=/var/run:/var/run:rw \ --volume=/sys/fs/cgroup/:/sys/fs/cgroup:ro \ From 605b0ae2447776d67fb260f65baef7728ec253a2 Mon Sep 17 00:00:00 2001 From: Jason Swindle Date: Tue, 10 Jun 2014 16:05:33 -0500 Subject: [PATCH 3/3] Dropping un-needed flags. --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index d7272506..5e4e65a8 100644 --- a/README.md +++ b/README.md @@ -12,8 +12,6 @@ To quickly tryout cAdvisor on your machine with Docker (version 0.11 or above), ``` sudo docker run \ - --interactive=false \ - --tty=true \ --volume=/var/run:/var/run:rw \ --volume=/sys/fs/cgroup/:/sys/fs/cgroup:ro \ --volume=/var/lib/docker/:/var/lib/docker:ro \