prometheus/cadvisor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix test with different order of Topology's nodes

Browse Source 
GetTopology provides Nodes not in order of Node.Id.
PR https://github.com/google/cadvisor/pull/2551 removed that check,
as result test acidentially passed.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
This commit is contained in:
Alexey Perevalov 2020-05-26 21:21:52 +03:00
parent 12c678119a
commit 2e2a4c496a
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
machine/topology_test.go
View File

@ -19,6 +19,7 @@ import (
"io/ioutil"
"os"
"reflect"
"sort"
"testing"
info "github.com/google/cadvisor/info/v1"
@ -263,6 +264,9 @@ func TestTopologyWithoutNodes(t *testing.T) {
sysFs.SetPhysicalPackageIDs(physicalPackageIDs, nil)
topology, numCores, err := GetTopology(sysFs)
sort.SliceStable(topology, func(i, j int) bool {
return topology[i].Id < topology[j].Id
})
assert.Nil(t, err)
assert.Equal(t, 2, len(topology))
assert.Equal(t, 4, numCores)