Updating inotify to fix memory leak

This commit is contained in:
Kris 2016-06-22 18:38:02 -07:00
parent e97c522721
commit 24e872fa73
2 changed files with 17 additions and 10 deletions

3
Godeps/Godeps.json generated
View File

@ -1,6 +1,7 @@
{ {
"ImportPath": "github.com/google/cadvisor", "ImportPath": "github.com/google/cadvisor",
"GoVersion": "go1.5", "GoVersion": "go1.5",
"GodepVersion": "v74",
"Packages": [ "Packages": [
"./..." "./..."
], ],
@ -459,7 +460,7 @@
}, },
{ {
"ImportPath": "golang.org/x/exp/inotify", "ImportPath": "golang.org/x/exp/inotify",
"Rev": "d00e13ec443927751b2bd49e97dea7bf3b6a6487" "Rev": "292a51b8d262487dab23a588950e8052d63d9113"
}, },
{ {
"ImportPath": "golang.org/x/net/context", "ImportPath": "golang.org/x/net/context",

View File

@ -144,6 +144,10 @@ func (w *Watcher) RemoveWatch(path string) error {
return os.NewSyscallError("inotify_rm_watch", errno) return os.NewSyscallError("inotify_rm_watch", errno)
} }
delete(w.watches, path) delete(w.watches, path)
// Locking here to protect the read from paths in readEvents.
w.mu.Lock()
delete(w.paths, int(watch.wd))
w.mu.Unlock()
return nil return nil
} }
@ -197,17 +201,19 @@ func (w *Watcher) readEvents() {
// the "Name" field with a valid filename. We retrieve the path of the watch from // the "Name" field with a valid filename. We retrieve the path of the watch from
// the "paths" map. // the "paths" map.
w.mu.Lock() w.mu.Lock()
event.Name = w.paths[int(raw.Wd)] name, ok := w.paths[int(raw.Wd)]
w.mu.Unlock() w.mu.Unlock()
if nameLen > 0 { if ok {
// Point "bytes" at the first byte of the filename event.Name = name
bytes := (*[syscall.PathMax]byte)(unsafe.Pointer(&buf[offset+syscall.SizeofInotifyEvent])) if nameLen > 0 {
// The filename is padded with NUL bytes. TrimRight() gets rid of those. // Point "bytes" at the first byte of the filename
event.Name += "/" + strings.TrimRight(string(bytes[0:nameLen]), "\000") bytes := (*[syscall.PathMax]byte)(unsafe.Pointer(&buf[offset+syscall.SizeofInotifyEvent]))
// The filename is padded with NUL bytes. TrimRight() gets rid of those.
event.Name += "/" + strings.TrimRight(string(bytes[0:nameLen]), "\000")
}
// Send the event on the events channel
w.Event <- event
} }
// Send the event on the events channel
w.Event <- event
// Move to the next event in the buffer // Move to the next event in the buffer
offset += syscall.SizeofInotifyEvent + nameLen offset += syscall.SizeofInotifyEvent + nameLen
} }