From fd0e4a160b685ce53376191ddfd9033fe76cada5 Mon Sep 17 00:00:00 2001 From: David Ashpole Date: Mon, 2 Mar 2020 09:55:14 -0800 Subject: [PATCH] don't update the latest tag anymore --- README.md | 3 ++- docs/development/releasing.md | 11 ++--------- docs/running.md | 3 ++- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 2aa99f4e..f0626eb2 100644 --- a/README.md +++ b/README.md @@ -11,6 +11,7 @@ cAdvisor has native support for [Docker](https://github.com/docker/docker) conta To quickly tryout cAdvisor on your machine with Docker, we have a Docker image that includes everything you need to get started. You can run a single cAdvisor to monitor the whole machine. Simply run: ``` +VERSION=v0.35.0 # use the latest release version from https://github.com/google/cadvisor/releases sudo docker run \ --volume=/:/rootfs:ro \ --volume=/var/run:/var/run:ro \ @@ -20,7 +21,7 @@ sudo docker run \ --publish=8080:8080 \ --detach=true \ --name=cadvisor \ - gcr.io/google-containers/cadvisor:latest + gcr.io/google-containers/cadvisor:$VERSION ``` cAdvisor is now running (in the background) on `http://localhost:8080`. The setup includes directories with Docker state cAdvisor needs to observe. diff --git a/docs/development/releasing.md b/docs/development/releasing.md index 13c8e0b4..7a45388c 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -89,13 +89,6 @@ Go to https://github.com/google/cadvisor/releases and click "Draft a new release ## 6. Finalize the release -Once you are satisfied with the release quality (consider waiting a week for bug reports to come in), it is time to promote the release to *latest* +~~Once you are satisfied with the release quality (consider waiting a week for bug reports to come in), it is time to promote the release to *latest*~~ -1. Edit the github release a final time, and uncheck the "Pre-release" checkbox -2. Tag the docker & gcr.io releases with the latest version -``` -$ docker pull google/cadvisor:$VERSION -$ docker tag -f google/cadvisor:$VERSION google/cadvisor:latest -$ docker tag -f google/cadvisor:$VERSION gcr.io/google_containers/cadvisor:latest -``` -3. Repeat steps 4.a and 4.b to push the image tagged with latest +cAdvisor is no longer pushed with the :latest tag. This is to ensure tagged images are immutable. diff --git a/docs/running.md b/docs/running.md index 8e0bc7b1..36869c81 100644 --- a/docs/running.md +++ b/docs/running.md @@ -5,6 +5,7 @@ We have a Docker image that includes everything you need to get started. Simply run: ``` +VERSION=v0.35.0 # use the latest release version from https://github.com/google/cadvisor/releases sudo docker run \ --volume=/:/rootfs:ro \ --volume=/var/run:/var/run:rw \ @@ -13,7 +14,7 @@ sudo docker run \ --publish=8080:8080 \ --detach=true \ --name=cadvisor \ - google/cadvisor:latest + google/cadvisor:$VERSION ``` cAdvisor is now running (in the background) on `http://localhost:8080/`. The setup includes directories with Docker state cAdvisor needs to observe.